Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart 0.1.1 creates invalid yaml with default values #441

Closed
RixTmobilender opened this issue Sep 28, 2021 · 2 comments · Fixed by #442
Closed

helm chart 0.1.1 creates invalid yaml with default values #441

RixTmobilender opened this issue Sep 28, 2021 · 2 comments · Fixed by #442
Assignees
Labels
bug Something isn't working
Milestone

Comments

@RixTmobilender
Copy link

Bug description

The default value for .Values.webhooks.ingresses.namespaceSelector includes a "matchExpressions" key that is being merged with the default webhook configuration resulting in invalid YAML

I believe this regression was introduced in this commit , by forgetting to delete lines L57-L59

How to reproduce

Install the helm chart with default values in dry run mode (helm template)

Expected behavior

Succesful templating of capsule release via helm chart, producing valid YAML.

Logs

If applicable, please provide logs of capsule.

line 3227: mapping key "matchExpressions" already defined at line 3224

Additional context

  • Capsule version: 0.1.0
  • Helm Chart version: 0.1.1
  • Kubernetes version: (kubectl version)
@RixTmobilender RixTmobilender added blocked-needs-validation Issue need triage and validation bug Something isn't working labels Sep 28, 2021
@MaxFedotov MaxFedotov self-assigned this Sep 29, 2021
@MaxFedotov
Copy link
Collaborator

Hi @RixTmobilender! Thank you for reporting this, definitely my typo. Will fix in a few hours.

@prometherion
Copy link
Member

Hey @RixTmobilender, should be fixed by the said MR, Charts is published here: update your Helm chart and open it back in case of any issue, and thanks for taking a look at Capsule!

@prometherion prometherion added this to the v0.1.1 milestone Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants