From e15191c2a0f158a234ff665e127a0149fc6724a7 Mon Sep 17 00:00:00 2001
From: Dario Tranchitella <dario@tranchitella.eu>
Date: Sun, 19 Jun 2022 14:30:14 +0200
Subject: [PATCH] refactor: sentinel error for running in out of cluster mode

---
 controllers/tls/errors.go  | 10 ++++++++++
 controllers/tls/manager.go | 21 +++++++++++++--------
 2 files changed, 23 insertions(+), 8 deletions(-)
 create mode 100644 controllers/tls/errors.go

diff --git a/controllers/tls/errors.go b/controllers/tls/errors.go
new file mode 100644
index 00000000..98a49bca
--- /dev/null
+++ b/controllers/tls/errors.go
@@ -0,0 +1,10 @@
+// Copyright 2020-2021 Clastix Labs
+// SPDX-License-Identifier: Apache-2.0
+
+package tls
+
+type RunningInOutOfClusterModeError struct{}
+
+func (r RunningInOutOfClusterModeError) Error() string {
+	return "cannot retrieve the leader Pod, probably running in out of the cluster mode"
+}
diff --git a/controllers/tls/manager.go b/controllers/tls/manager.go
index 29fb65d2..1b9c87a7 100644
--- a/controllers/tls/manager.go
+++ b/controllers/tls/manager.go
@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/go-logr/logr"
+	"github.com/pkg/errors"
 	"golang.org/x/sync/errgroup"
 	admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
 	corev1 "k8s.io/api/core/v1"
@@ -121,11 +122,6 @@ func (r Reconciler) ReconcileCertificates(ctx context.Context, certSecret *corev
 		return fmt.Errorf("missing %s field in %s secret", corev1.ServiceAccountRootCAKey, r.Configuration.TLSSecretName())
 	}
 
-	operatorPods, err := r.getOperatorPods(ctx)
-	if err != nil {
-		return err
-	}
-
 	r.Log.Info("Updating caBundle in webhooks and crd")
 
 	group := new(errgroup.Group)
@@ -139,6 +135,17 @@ func (r Reconciler) ReconcileCertificates(ctx context.Context, certSecret *corev
 		return r.updateCustomResourceDefinition(ctx, caBundle)
 	})
 
+	operatorPods, err := r.getOperatorPods(ctx)
+	if err != nil {
+		if errors.As(err, &RunningInOutOfClusterModeError{}) {
+			r.Log.Info("skipping annotation of Pods for cert-manager", "error", err.Error())
+
+			return nil
+		}
+
+		return err
+	}
+
 	r.Log.Info("Updating capsule operator pods")
 
 	for _, pod := range operatorPods.Items {
@@ -326,9 +333,7 @@ func (r Reconciler) getOperatorPods(ctx context.Context) (*corev1.PodList, error
 	leaderPod := &corev1.Pod{}
 
 	if err := r.Client.Get(ctx, types.NamespacedName{Namespace: os.Getenv("NAMESPACE"), Name: hostname}, leaderPod); err != nil {
-		r.Log.Error(err, "cannot retrieve the leader Pod, probably running in out of the cluster mode")
-
-		return nil, err
+		return nil, RunningInOutOfClusterModeError{}
 	}
 
 	podList := &corev1.PodList{}