Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bootstrap 5 #3018

Closed
jcoyne opened this issue Jun 20, 2024 · 4 comments
Closed

Upgrade to Bootstrap 5 #3018

jcoyne opened this issue Jun 20, 2024 · 4 comments
Assignees

Comments

@jcoyne
Copy link
Member

jcoyne commented Jun 20, 2024

Bootstrap 4 was EOL over a year and a half ago and is unsupported. https://getbootstrap.com/docs/4.6/end-of-life/

@corylown
Copy link
Contributor

corylown commented Jul 22, 2024

Bootstrap 4 to 5.3 migration guide: https://getbootstrap.com/docs/5.3/migration/
Example of work done to add support for Bootstrap 5 to Blacklight: https://github.com/projectblacklight/blacklight/pull/2459/files
Since we're planning a major version update for Spotlight (from 3 to 4) now may be a good time to drop support for Bootstrap 4 in Spotlight.

@corylown corylown self-assigned this Jul 26, 2024
@corylown
Copy link
Contributor

corylown commented Jul 26, 2024

Looks like we might also need to update blacklight-gallery for Bootstrap 5 https://github.com/search?q=repo%3Aprojectblacklight%2Fblacklight-gallery%20data-slide&type=code

WIP here projectblacklight/blacklight-gallery#144

@corylown
Copy link
Contributor

corylown commented Jul 26, 2024

WIP for Spotlight: main...bootstrap-5

Still to do:

  • Commented out css needs review for updated bootstrap variables or different approach
  • Carousel related JS needs to work with both Bootstrap 4 or 5.
  • Figure out what else I've missed causing bootstrap button/dropdowns not to work
  • Style adjustments

@corylown
Copy link
Contributor

Closed by #3075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants