Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport search bar improvements #2873

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Backport search bar improvements #2873

merged 5 commits into from
Nov 9, 2022

Commits on Nov 8, 2022

  1. port aria-label change to search_bar_component.html.erb and spec to a… 

    … Blacklight::SearchBarComponent spec
    @barmintor @cbeer
    barmintor authored and cbeer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    98cc04c View commit details
    Browse the repository at this point in the history

  2. Pass form options through the search bar component

    @cbeer
    cbeer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    1bd62d7 View commit details
    Browse the repository at this point in the history

  3. Allow the search button to be passed into the search bar using a slot 

    This gives the user a way of customizing the search button without having to override the SearchBarComponent
    @jcoyne @cbeer
    jcoyne authored and cbeer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b734bb7 View commit details
    Browse the repository at this point in the history

  4. Fix rendering of slot values

    @jcoyne @cbeer
    jcoyne authored and cbeer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    ad5847a View commit details
    Browse the repository at this point in the history

  5. Add a slot for rendering extra inputs in the search bar 

    Refs #2862 and #2863
    @thatbudakguy @cbeer
    thatbudakguy authored and cbeer committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    75bf8cb View commit details
    Browse the repository at this point in the history