Skip to content

Commit

Permalink
Remove unused bloodhound-js dependency. (#2846)
Browse files Browse the repository at this point in the history
* Remove unused bloodhound-js dependency.

Pre-existing code is using a `Bloodhound` object actually from alternate `typeahead.js` package, see:

https://github.com/projectblacklight/blacklight/blob/v7.31.0/app/javascript/blacklight/autocomplete.js#L2

   import Bloodhound from 'typeahead.js/dist/bloodhound.js'

That is importing Bloodhound from typeahead.js package, not from bloodhound-js package. As far as I can tell, no use of `bloodhound-js` package is actually being made, so the dependency is unnecessary. Eliminating it will keep blacklight-consuming builds faster and smaller with simpler dependency trees.
  • Loading branch information
jrochkind authored Oct 19, 2022
1 parent 9e1acbf commit fba20c8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
},
"browserslist": "> 0.25%, not dead",
"dependencies": {
"bloodhound-js": "^1.2.3",
"bootstrap": ">=4.3.1 <6.0.0",
"jquery": "^3.5.1",
"typeahead.js": "^0.11.1"
Expand Down

0 comments on commit fba20c8

Please sign in to comment.