papercut-fix: perform login on enter button press for basic auth in the login page #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
papercut-fix
Which issue does this PR fix:
Closes #430
What does this PR do / Why do we need it:
This PR contains the following changes:
Enter
button in the login page's username or password fields, it performs submit only if both username and password fields have some data in them (neither of them are blank).SignIn
component from test cases.data-testid
for the OpenID Divider to avoid an error being shown in the Unit Test runs.Testing done on this change:
Pressing Enter on a fresh login page:
Pressing Enter on the username field while password is blank:
Pressing Enter on the password field while the username is blank:
Pressing Enter on password field after entering both username and password results in a successful login.
Automation added to e2e:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A - this is a UI-only change for the login page.
Does this change require updates to the CNI daemonset config files to work?:
N/A
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.