Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't display divider for API Keys menu item when API key is disabled #433

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

vrajashkr
Copy link
Contributor

What type of PR is this?
bug

Which issue does this PR fix:
Closes #424

What does this PR do / Why do we need it:
This PR fixes a bug where 2 horizontal lines show up in the User Account menu when the API key setting is disabled.

Testing done on this change:
With API keys disabled:
Screenshot from 2024-03-20 21-35-21

With API keys enabled:
Screenshot from 2024-03-20 21-39-32

Automation added to e2e:
N/A

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Not expected to break upgrades or downgrades. Not tested on a cluster.

Does this change require updates to the CNI daemonset config files to work?:
None

Does this PR introduce any user-facing change?:
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.35%. Comparing base (09ab447) to head (98f5a43).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   82.70%   83.35%   +0.65%     
==========================================
  Files          63       63              
  Lines        1885     1887       +2     
  Branches      485      498      +13     
==========================================
+ Hits         1559     1573      +14     
+ Misses        315      303      -12     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andaaron andaaron requested a review from raulkele March 20, 2024 18:06
@andaaron andaaron merged commit 9de2337 into project-zot:main Mar 24, 2024
8 checks passed
@andaaron
Copy link
Contributor

Thank you!

@vrajashkr vrajashkr deleted the fix/user-account-menu branch March 25, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ZUI][User meu] two horizontal lines between the username and the "Log Out" button.
2 participants