Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Improve logging #14

Open
rbehjati opened this issue Feb 3, 2022 · 2 comments
Open

Improve logging #14

rbehjati opened this issue Feb 3, 2022 · 2 comments
Labels

Comments

@rbehjati
Copy link
Contributor

rbehjati commented Feb 3, 2022

Currently, we log errors from running the command (exec.Command) in a tempfile.
These files are difficult to access on GitHub, in case, a CI step fails.

Should we instead log everything to console?

The problem with that is that the logs may get very messy and difficult to use.

@jul-sh
Copy link
Contributor

jul-sh commented Feb 4, 2022

I think this is a good idea, and would also simplify our code substantially. If messy logs an issue we can consider adding a "verbose" flag?

@rbehjati
Copy link
Contributor Author

rbehjati commented Feb 4, 2022

Yes. I think a verbose flag would be a good idea :) Not sure how to implement it nicely though.

@rbehjati rbehjati added the Core label Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants