Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running hello_world example doesn't include the translator #901

Closed
daviddrysdale opened this issue Apr 24, 2020 · 1 comment · Fixed by #993
Closed

Running hello_world example doesn't include the translator #901

daviddrysdale opened this issue Apr 24, 2020 · 1 comment · Fixed by #993
Assignees
@ipetr0v
Labels
lang/Shell P2

Comments

@daviddrysdale
Copy link
Contributor

The Wasm module for the translator is built by scripts/build_example -e hello_world (as a special case), and two versions of the application config are built (config.bin and config_translator.bin), but scripts/run_example -e hello_world uses the version without the translator module included.
@ipetr0v
Copy link
Contributor

ipetr0v commented Apr 24, 2020

Should the translator version be the default one? Or it needs to run both?

@daviddrysdale daviddrysdale mentioned this issue May 19, 2020
Merged
4 tasks
@ipetr0v ipetr0v self-assigned this May 20, 2020
ipetr0v added a commit that referenced this issue May 21, 2020
@ipetr0v
Use Rust Loader for running examples (#993)
68fbbe3 
This change:
- Updates examples to use Rust Loader
- Updates macro and scripts for running Rust Loader
- Makes Oak CI to use Rust Loader for running examples
- Builds Rust Oak Loader with Cargo
- Fixes minor issues with gRPC server/client pseudo-Nodes

Fixes #725
Fixes #874
Fixes #901
Ref #945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ipetr0v ipetr0v

Labels
lang/Shell P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Rust Loader for running examples ipetr0v/oak
2 participants
@daviddrysdale @ipetr0v