Fix integer attrib convertion with signed integer type (#1246) #1258
Conversation
|
|
ben1hop
force-pushed
the
feature/ZAPP-1323
branch
from
510ecf6
to
b3a6b35
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
+ Coverage 65.21% 65.29% +0.08%
==========================================
Files 188 188
Lines 19722 19834 +112
Branches 4217 4245 +28
==========================================
+ Hits 12861 12950 +89
- Misses 6861 6884 +23 ☔ View full report in Codecov by Sentry. |
| let fakeEndpointAttribute = { | ||
| defaultValue: '30', | ||
| } | ||
|
|
||
| let fakeAttribute = { | ||
| type: 'UINT16', | ||
| type: 'int16u', |
There was a problem hiding this comment.
while testing the queryZcl.selectNumberByNameAndClusterId() returned nothing with the upper case one
my locally built zap tool also uses the lower case format whenever i edit an attribute, why was the other one used in the first place?
There was a problem hiding this comment.
How was this passing before?
The xml can vary how it represents unsigned 16 bit integers. I believe both representations exist based on matter/zigbee as of today.
There was a problem hiding this comment.
the validation did not check for specific integer types before my implementation, only decided if the input string can be an integer and its unsigned value within bounds
ben1hop
force-pushed
the
feature/ZAPP-1323
branch
from
b3a6b35
to
34aec67
Compare
No description provided.