Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chip_server_cluster_attributes returning attributes of a clusters which are disabled #898

Closed
brdandu opened this issue Jan 19, 2023 · 2 comments · Fixed by #899
Closed

chip_server_cluster_attributes returning attributes of a clusters which are disabled #898

brdandu opened this issue Jan 19, 2023 · 2 comments · Fixed by #899
Assignees
@brdandu
Labels
component: back-end Back-end work only, no user interface changes MatterZapCleanup

Comments

@brdandu
Copy link
Collaborator

brdandu commented Jan 19, 2023

Seeing that chip_server_cluster_attributes is returning server side attributes when the server side cluster is actually disabled. This seems unintentional for generation. If you see the zap UI for this then you will see the attributes are not actually enabled for the server side.
Fix this using a stateless helper such as all_user_cluster_attributes_irrespective_of_manufacturing_specification
@brdandu brdandu self-assigned this Jan 19, 2023
@brdandu brdandu linked a pull request Jan 20, 2023 that will close this issue
Adding to zcl_attributes_server and enabled_attributes_for_cluster_and_side helpers to replace chip_server_cluster_attributes #899
Merged
@tecimovic tecimovic added the component: back-end Back-end work only, no user interface changes label Jan 30, 2023
@brdandu
Copy link
Collaborator Author

brdandu commented Mar 14, 2023 •
edited
Loading

Corresponding chip repo PR for non java templates changes: project-chip/connectedhomeip#25687

Corresponding chip repo PR for java and python template changes: project-chip/connectedhomeip#25693

@brdandu
Copy link
Collaborator Author

brdandu commented Mar 16, 2023

Re-opening until Chip repo PRs are merged.

@brdandu brdandu reopened this Mar 16, 2023
@brdandu brdandu closed this as completed Mar 23, 2023
@brdandu brdandu mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brdandu brdandu

Labels
component: back-end Back-end work only, no user interface changes MatterZapCleanup
Projects
None yet
Milestone
No milestone
2 participants
@tecimovic @brdandu