-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the src/controller tests on all platforms except nrfconnect. #9638
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:enable-controller-tests
Sep 13, 2021
Merged
Enable the src/controller tests on all platforms except nrfconnect. #9638
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:enable-controller-tests
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack usage bit is not OK. See #8558 }}connectedhomeip/src/app/zap-templates/templates/app/CHIPClientCallbacks-src.zapt Lines 341 to 348 in bb11782
This comment was generated by todo based on a
|
This stack usage bit is not OK. See #8558 }}connectedhomeip/src/app/zap-templates/templates/app/CHIPClientCallbacks-src.zapt Lines 395 to 401 in bb11782
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
September 13, 2021 15:48
mspang
reviewed
Sep 13, 2021
1) Modify our CHIPClientCallbacks template to suppress the "possibly unbounded stack" warning from a VLA we know we want to remove. 2) Don't try to link in BLELayer in the TestDevice test if BLE networking is disabled (so that BLELayer symbols don't actually exist). 3) Heap-allocate the huge FabricTable so we don't run into compile errors due to a stack frame being too big in TestDevice. 4) Fix the fact that SystemLayerImplSelect did not default-initialize mDispatchQueue. This matters because TestDevice does weird things with a separate SystemLayer that the PlatformManager does not know about, nor does it call InitChipStack in any case. The tests are still disabled on nrfconnect because I could not get them to link there so far. Fixes project-chip#9173
bzbarsky-apple
force-pushed
the
enable-controller-tests
branch
from
September 13, 2021 18:24
bb11782
to
e9512c4
Compare
woody-apple
approved these changes
Sep 13, 2021
jmartinez-silabs
approved these changes
Sep 13, 2021
saurabhst
approved these changes
Sep 13, 2021
Size increase report for "esp32-example-build" from 92d3a28
Full report output
|
andy31415
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unbounded stack" warning from a VLA we know we want to remove.
networking is disabled (so that BLELayer symbols don't actually
exist).
errors due to a stack frame being too big in TestDevice.
mDispatchQueue. This matters because TestDevice does weird things
with a separate SystemLayer that the PlatformManager does not know
about, nor does it call InitChipStack in any case.
The tests are still disabled on nrfconnect because I could not get
them to link there so far.
Fixes #9173
Problem
Tests were disabled on Darwin, probably because the actual test BUILD.gn did not spell "darwin" right, so did not end up linking in the right things, so linking failed.
Change overview
Always link in the right things, plus the items above.
Testing
CI passes.