-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for CHIPMemString. #9619
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
September 11, 2021 00:52
Size increase report for "esp32-example-build" from eda07d5
Full report output
|
bzbarsky-apple
approved these changes
Sep 11, 2021
Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
approved these changes
Sep 13, 2021
andy31415
reviewed
Sep 13, 2021
andy31415
approved these changes
Sep 13, 2021
Use buf len instead of strlen to make it more clear about what the buffer sizes really mean.
andy31415
approved these changes
Sep 13, 2021
emargolis
approved these changes
Sep 13, 2021
woody-apple
approved these changes
Sep 13, 2021
jmartinez-silabs
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I wanted to add something in CHIPMemString and noticed that we didn't have any tests currently.
Change overview
Add tests for functionality currently in CHIPMemString.
Testing
Added new unit tests and nothing else. Verified that the new tests are running by forcing a failure.