-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PASE state machine to match the latest specifications #9582
Conversation
* Use TLV formatted messages * Use StatusReport to indicate errors and completion
Size increase report for "gn_qpg-example-build" from fce8561
Full report output
|
Size increase report for "nrfconnect-example-build" from fce8561
Full report output
|
Size increase report for "esp32-example-build" from fce8561
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved conditional on the few comments marked with 👀 emoji being resolved
- Update <Set/Get><Local/Peer>KeyId() functions to <Set/Get><Local/Peer>SessionId()connectedhomeip/src/protocols/secure_channel/PASESession.cpp Lines 415 to 425 in bea61e6
This comment was generated by todo based on a
|
- Add a unit test that exercises mHavePBKDFParameters pathconnectedhomeip/src/protocols/secure_channel/PASESession.cpp Lines 531 to 541 in bea61e6
This comment was generated by todo based on a
|
- Move SendStatusReport to a common part of the code.connectedhomeip/src/protocols/secure_channel/PASESession.cpp Lines 792 to 802 in bea61e6
This comment was generated by todo based on a
|
- Move EstimateTLVStructOverhead to CHIPTLV header fileconnectedhomeip/src/protocols/secure_channel/PASESession.h Lines 273 to 283 in bea61e6
This comment was generated by todo based on a
|
- Update <Set/Get><Local/Peer>KeyId() functions to <Set/Get><Local/Peer>SessionId()connectedhomeip/src/protocols/secure_channel/PASESession.cpp Lines 415 to 425 in 27dd893
This comment was generated by todo based on a
|
Problem
PASE state machine code is out of date compared to latest specifications.
Change overview
Update the code to match the specifications.
Testing
TestPASESession
unit test.Tested PASE flow using all-cluster app and chip-tool commissioner.