From bd1b03a3a716b33896dd58184c8e03195e5476b2 Mon Sep 17 00:00:00 2001 From: Michael Spang Date: Wed, 16 Jun 2021 01:14:29 -0400 Subject: [PATCH] Revert "Fix XML comments in opcreds cluster (#7598)" This reverts commit 0e2917466616f603773adf6a5b2a49f330ac86e4. --- .../zcl/operational-credentials-cluster.xml | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/app/zap-templates/zcl/operational-credentials-cluster.xml b/src/app/zap-templates/zcl/operational-credentials-cluster.xml index dd2397b1e043fe..ce6c4eaef017b6 100644 --- a/src/app/zap-templates/zcl/operational-credentials-cluster.xml +++ b/src/app/zap-templates/zcl/operational-credentials-cluster.xml @@ -19,27 +19,27 @@ limitations under the License. General Operational Credentials - 0x003E + 0x003E // Change to correct clusterID once it is decided in the spec #2396 OPERATIONAL_CREDENTIALS_CLUSTER This cluster is used to add or remove Operational Credentials on a Commissionee or Node, as well as manage the associated Fabrics. fabrics list - + /* + * Temporary flow for fabric management until addOptCert + fabric index are implemented: + * 1) When Commissioner pairs with CHIP device, store device nodeId in Admin Pairing table as NodeId + * and store commissioner nodeId in Admin Pairing table as FabricId (This is temporary until AddOptCert is implemented and Fabrics are implemented correctely) + * 2) When pairing is complete, commissioner calls SetFabric to set the vendorId on the newly created fabric. The corresponding fabric is found by looking + * in admin pairing table and finding a fabric that has the matching commissioner node ID as fabricId + device nodeId as nodeId and an uninitialized vendorId. + * 3) RemoveFabric uses the passed in fabricId, nodeId, vendorID to find matching entry and remove it from admin pairing table. Once fabricIndex is implemented, it should use that instead. + */ This command SHALL be used by an Administrative Node to set the user-visible Label field for a given Fabric, as reflected by entries in the Fabrics attribute. - + // TODO: Once FabricIndex is implemented, have RemoveFabric take an index instead of vid+fabricId+nopeId This command is used by Administrative Nodes to remove a given Fabric and delete all associated fabric-scoped data. @@ -48,7 +48,7 @@ fabric-scoped data. - + // TODO: Remove SetFabric + SetFabricResponse once addOptCert command is implemented Sets the vendorID of the fabric and returns the fabricId of newly created fabric. @@ -59,7 +59,7 @@ fabric-scoped data. - + // Up for discussion in Multi-Admin TT: chip-spec:#2891 Removes all fabrics. @@ -69,7 +69,6 @@ fabric-scoped data. - A certificate signing request (CSR) from the server.