Missing log function in Zephyr standalone platform #34413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caldeira, Quentin <[email protected]>
I've created this one with the previous PR, but I didn't see that it was ignored by .gitignore because I named it Kconfig.log, so rename it to Kconfig.logging Always with the purpose to separate each function in a dedicated Kconfig to source in your application, to avoid Kconfig warning, and let your prj.conf be application configuration only Signed-off-by: Caldeira, Quentin <[email protected]>
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kiel-apple
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
Because every zephyr's user seems to rely on the zephyr logging system, move the log declaration into the zephyr folder Signed-off-by: Caldeira, Quentin <[email protected]>
|
PR #34413: Size comparison from fca7948 to ff18e91 Full report (93 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
approved these changes
Jul 19, 2024
andy31415
approved these changes
Jul 19, 2024
|
PR #34413: Size comparison from 3bc5667 to 983e966 Full report (96 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add missing log option Signed-off-by: Caldeira, Quentin <[email protected]> * Add missing logging Kconfig I've created this one with the previous PR, but I didn't see that it was ignored by .gitignore because I named it Kconfig.log, so rename it to Kconfig.logging Always with the purpose to separate each function in a dedicated Kconfig to source in your application, to avoid Kconfig warning, and let your prj.conf be application configuration only Signed-off-by: Caldeira, Quentin <[email protected]> * Move CHIP_APP_LOG_LEVEL Because every zephyr's user seems to rely on the zephyr logging system, move the log declaration into the zephyr folder Signed-off-by: Caldeira, Quentin <[email protected]> --------- Signed-off-by: Caldeira, Quentin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't issue-related, but I've seen that Kconfig.log wasn't added in the previous PR for zephyr standalone platform, because of
.gitignoreignoring all.logfiles. This leads to a non-functional logging system when building for standalone zephyr.