-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MRP SessionIdleInterval per spec to 500ms #32124
Merged
mergify
merged 2 commits into
project-chip:master
from
samadDotDev:fix/mrp-idle-interval
Feb 14, 2024
Merged
Fix MRP SessionIdleInterval per spec to 500ms #32124
mergify
merged 2 commits into
project-chip:master
from
samadDotDev:fix/mrp-idle-interval
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec has the default SESSION_IDLE_INTERVAL defined as 500ms https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/1.2/src/secure_channel/Message_Reliability_MRP.adoc#8-parameters-and-constants Originally defined as 300ms, this change was introduced as part of spec PR CHIP-Specifications/connectedhomeip-spec#7186
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 14, 2024 17:30
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
February 14, 2024 17:30
PR #32124: Size comparison from 598356c to faffa65 Increases (38 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, qpg, stm32, telink)
Decreases (2 builds for efr32, linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Damian-Nordic
approved these changes
Feb 14, 2024
Reflecting the spec update CHIP-Specifications/connectedhomeip-spec#7186
PR #32124: Size comparison from 598356c to 047e31f Increases (40 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (9 builds for efr32, esp32, linux, nrfconnect, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Feb 14, 2024
raul-marquez-csa
pushed a commit
to raul-marquez-csa/connectedhomeip
that referenced
this pull request
Feb 16, 2024
* Fix MRP SessionIdleInterval per spec to 500ms Spec has the default SESSION_IDLE_INTERVAL defined as 500ms https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/1.2/src/secure_channel/Message_Reliability_MRP.adoc#8-parameters-and-constants Originally defined as 300ms, this change was introduced as part of spec PR CHIP-Specifications/connectedhomeip-spec#7186 * Update Sleepy -> Session in context of active/idle intervals Reflecting the spec update CHIP-Specifications/connectedhomeip-spec#7186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec has the default
SESSION_IDLE_INTERVAL
defined as500ms
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/1.2/src/secure_channel/Message_Reliability_MRP.adoc#8-parameters-and-constantsOriginally defined as
300ms
, this change was introduced as part of spec PR https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7186This PR just updates the default and local MRP values in SDK to reflect that.