-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade labeler config to v5 from v4 #30996
Merged
andy31415
merged 6 commits into
project-chip:master
from
vatsalghelani-csa:CIdevelopment/labelerv5upgrade
Dec 14, 2023
Merged
Upgrade labeler config to v5 from v4 #30996
andy31415
merged 6 commits into
project-chip:master
from
vatsalghelani-csa:CIdevelopment/labelerv5upgrade
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the version upgrade to v5.0.0 from v4
Correcting the syntax to configure file
Correcting the syntax to configure file
Correcting the syntax to configure file
PR #30996: Size comparison from 7378446 to 6b92881 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Dec 14, 2023
@vatsalghelani-csa you need to sign the CLA (link available on the CLA check) |
arkq
approved these changes
Dec 14, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
cliffamzn,
Damian-Nordic,
dhrishi,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
December 14, 2023 16:18
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple and
younghak-hwang
December 14, 2023 16:18
…ead of v5.0.0 Changing workflow to the major version v5 instead of v5.0.0
PR #30996: Size comparison from 7378446 to fabeb78 Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Decreases (37 builds for bl602, bl702, bl702l, cc13x4_26x4, efr32, esp32, linux, nrfconnect, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
pushed a commit
to andy31415/connectedhomeip
that referenced
this pull request
Dec 14, 2023
This reverts commit eaf3aa3.
andy31415
added a commit
that referenced
this pull request
Dec 14, 2023
This reverts commit eaf3aa3. Co-authored-by: Andrei Litvin <[email protected]>
This was referenced Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30930
Currently https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/labeler.yaml our labeler yaml is pointing to the version v4.
Seems to have broken label CI actions (which is ugly because the CI itself passed, it just fails on other PRs like https://github.com/project-chip/connectedhomeip/actions/runs/7169114229/job/19518884500?pr=30921)
https://github.com/flutter/flutter/pull/139564/files#diff-a22c263686553013feaeb0677d26eeb0b8778a756c4311c1fce13384258026aaR23