-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Update root device type to include icdm cluster #30008
Merged
mkardous-silabs
merged 3 commits into
project-chip:master
from
mkardous-silabs:feature/update_root_xml
Nov 1, 2023
Merged
[ICD] Update root device type to include icdm cluster #30008
mkardous-silabs
merged 3 commits into
project-chip:master
from
mkardous-silabs:feature/update_root_xml
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248 and
hicklin
October 25, 2023 17:52
pullapprove
bot
requested review from
wiba-nordic,
tcarmelveilleux,
woody-apple,
tecimovic,
younghak-hwang,
tima-q,
tobiasgraf,
yufengwangca,
turon,
yunhanw-google and
vivien-apple
October 25, 2023 17:52
PR #30008: Size comparison from 4823e34 to aadfe70 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 30, 2023
bzbarsky-apple
approved these changes
Oct 31, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spec added the ICDM cluster to root node device type.
Adding it in the SDK.
fixes #26798