-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scenes] Enabling TableSize feature #29762
Merged
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_enable_table_size
Oct 18, 2023
Merged
[Scenes] Enabling TableSize feature #29762
mergify
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:feature/scenes_enable_table_size
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_table_size
branch
from
October 13, 2023 17:56
da39073
to
42852dd
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
October 13, 2023 17:56
bzbarsky-apple
approved these changes
Oct 17, 2023
PR #29762: Size comparison from 462c79a to 7e5a35e Increases above 0.2%:
Increases (24 builds for bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Oct 17, 2023
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_table_size
branch
from
October 17, 2023 18:10
c2468b7
to
074f8ed
Compare
PR #29762: Size comparison from 4df48ef to 074f8ed Increases (18 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for efr32, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_table_size
branch
from
October 17, 2023 22:26
074f8ed
to
9733291
Compare
ScenesTableImpl would get the value from zap
…e and adapted the tests
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_table_size
branch
from
October 17, 2023 22:36
2efedb2
to
6e7e0ea
Compare
lpbeliveau-silabs
force-pushed
the
feature/scenes_enable_table_size
branch
from
October 17, 2023 22:45
6e7e0ea
to
e29ad66
Compare
PR #29762: Size comparison from 769ac9f to e29ad66 Increases (18 builds for cc13x4_26x4, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for efr32, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rcasallas-silabs
approved these changes
Oct 18, 2023
Jaehoon-You
added a commit
to Jaehoon-You/connectedhomeip
that referenced
this pull request
Oct 20, 2023
- Updated by '[Scenes] Enabling TableSize feature (project-chip#29762)' Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
- Updated by '[Scenes] Enabling TableSize feature (#29762)' Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Added the TableSize bit to the Scenes feature map and ensured the ScenesTableImpl would get the value from zap * Updated Fabric capacity rule to apply less than half of SceneTableSize and adapted the tests * Generated Zap * Adapted the tests to handle new Capacity in spec and regenerated Darwin tests * Attempt to fix signedness error on Darwin CI * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
- Updated by '[Scenes] Enabling TableSize feature (project-chip#29762)' Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
* Added the TableSize bit to the Scenes feature map and ensured the ScenesTableImpl would get the value from zap * Updated Fabric capacity rule to apply less than half of SceneTableSize and adapted the tests * Generated Zap * Adapted the tests to handle new Capacity in spec and regenerated Darwin tests * Attempt to fix signedness error on Darwin CI * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
- Updated by '[Scenes] Enabling TableSize feature (project-chip#29762)' Signed-off-by: Jaehoon You <[email protected]> Signed-off-by: Charles Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the TableSize bit to the Scenes feature map and ensured the ScenesTableImpl would get the value from zap.