-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ICD nomenclature in the app/icd/ implementation #29687
Merged
mergify
merged 3 commits into
project-chip:master
from
jmartinez-silabs:renaming_icd_to_uppercase
Oct 11, 2023
Merged
Align ICD nomenclature in the app/icd/ implementation #29687
mergify
merged 3 commits into
project-chip:master
from
jmartinez-silabs:renaming_icd_to_uppercase
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
lib
app
tests
support
icd
Intermittently Connected Devices
labels
Oct 10, 2023
jmartinez-silabs
changed the title
Align ICD nommenclature in the app/icd/ file implementation
Align ICD nommenclature in the app/icd/ implementation
Oct 10, 2023
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmeg-sfy and
joonhaengHeo
October 10, 2023 17:20
pullapprove
bot
requested review from
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 10, 2023 17:20
PR #29687: Size comparison from f40823f to 4c2493d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Oct 10, 2023
rcasallas-silabs
approved these changes
Oct 10, 2023
jmartinez-silabs
changed the title
Align ICD nommenclature in the app/icd/ implementation
Align ICD nomenclature in the app/icd/ implementation
Oct 10, 2023
saurabhst
approved these changes
Oct 11, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…9687) * Align ICD nommenclature in the app/icd/ file implementation * Restyled by clang-format * rename TestIcdMonitoringTable.cpp --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files, class, variables were using Icd instead of ICD. Align them with the rest of the implementation from
src/app/icd/
cleanup the icd source-set names