Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-source-app should not be a Diagnostic Logs client. #29662

Merged
merged 1 commit into from
Oct 10, 2023
Merged

log-source-app should not be a Diagnostic Logs client. #29662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions examples/log-source-app/log-source-common/log-source-app.matter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,51 +268,6 @@ server cluster NetworkCommissioning = 49 {
command access(invoke: administer) ReorderNetwork(ReorderNetworkRequest): NetworkConfigResponse = 8;
}

/** The cluster provides commands for retrieving unstructured diagnostic logs from a Node that may be used to aid in diagnostics. */
client cluster DiagnosticLogs = 50 {
enum IntentEnum : ENUM8 {
kEndUserSupport = 0;
kNetworkDiag = 1;
kCrashLogs = 2;
}

enum StatusEnum : ENUM8 {
kSuccess = 0;
kExhausted = 1;
kNoLogs = 2;
kBusy = 3;
kDenied = 4;
}

enum TransferProtocolEnum : ENUM8 {
kResponsePayload = 0;
kBDX = 1;
}

readonly attribute command_id generatedCommandList[] = 65528;
readonly attribute command_id acceptedCommandList[] = 65529;
readonly attribute event_id eventList[] = 65530;
readonly attribute attrib_id attributeList[] = 65531;
readonly attribute bitmap32 featureMap = 65532;
readonly attribute int16u clusterRevision = 65533;

request struct RetrieveLogsRequestRequest {
IntentEnum intent = 0;
TransferProtocolEnum requestedProtocol = 1;
optional CHAR_STRING<32> transferFileDesignator = 2;
}

response struct RetrieveLogsResponse = 1 {
StatusEnum status = 0;
LONG_OCTET_STRING logContent = 1;
optional epoch_us UTCTimeStamp = 2;
optional systime_us timeSinceBoot = 3;
}

/** Retrieving diagnostic logs from a Node */
command RetrieveLogsRequest(RetrieveLogsRequestRequest): RetrieveLogsResponse = 0;
}

/** The cluster provides commands for retrieving unstructured diagnostic logs from a Node that may be used to aid in diagnostics. */
server cluster DiagnosticLogs = 50 {
enum IntentEnum : ENUM8 {
Expand Down Expand Up @@ -468,7 +423,6 @@ server cluster OperationalCredentials = 62 {
endpoint 0 {
device type ma_all_clusters_app = 0, version 1;

binding cluster DiagnosticLogs;

server cluster AccessControl {
emits event AccessControlEntryChanged;
Expand Down
8 changes: 0 additions & 8 deletions examples/log-source-app/log-source-common/log-source-app.zap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,14 +470,6 @@
}
]
},
{
"name": "Diagnostic Logs",
"code": 50,
"mfgCode": null,
"define": "DIAGNOSTIC_LOGS_CLUSTER",
"side": "client",
"enabled": 1
},
{
"name": "Diagnostic Logs",
"code": 50,
Expand Down
Loading