-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for the 917 BLE power cycle issue fix #29628
Merged
mergify
merged 4 commits into
project-chip:master
from
shgutte:bugfix/917_issue_with_power_cycle
Oct 10, 2023
Merged
Added fix for the 917 BLE power cycle issue fix #29628
mergify
merged 4 commits into
project-chip:master
from
shgutte:bugfix/917_issue_with_power_cycle
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29628: Size comparison from c73199d to 50935bc Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple and
lazarkov
October 9, 2023 10:40
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 9, 2023 10:40
shgutte
changed the title
Added fix for the 917 BLE power cycle issue
Added fix for the 917 BLE power cycle issue fix and 917 BLE additional data advertisement changes
Oct 9, 2023
shgutte
changed the title
Added fix for the 917 BLE power cycle issue fix and 917 BLE additional data advertisement changes
Added fix for the 917 BLE power cycle issue fix
Oct 9, 2023
shgutte
force-pushed
the
bugfix/917_issue_with_power_cycle
branch
from
October 9, 2023 10:56
9385bae
to
50935bc
Compare
PR #29628: Size comparison from 52225dd to 4b20ad3 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 10, 2023
andy31415
approved these changes
Oct 10, 2023
brosahay
reviewed
Oct 11, 2023
#else | ||
#define RSI_EXT_CUSTOM_FEATURE_BIT_MAP (SL_SI91X_EXT_FEAT_LOW_POWER_MODE | SL_SI91X_EXT_FEAT_XTAL_CLK_ENABLE(2)) | ||
#endif /* CHIP_9117 */ | ||
#endif /* WIFI_ENABLE_SECURITY_WPA3_TRANSITION */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this configuration removed?
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Added fix for the BLE power cycle issue * Added restyle changes * Added restyle changes * Added changes for the ble config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fix :
Tested: