-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Improve MTRAsyncWorkQueue logging by tracking unique item ids #29568
Darwin: Improve MTRAsyncWorkQueue logging by tracking unique item ids #29568
Conversation
Also return more information from the batching handler so we can log both partial and full batching from the queue itself.
0560267
to
16e9c08
Compare
PR #29568: Size comparison from 73c327e to 16e9c08 Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29568: Size comparison from 73c327e to 5fed982 Increases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestions are basically so we can consistently search for "work item NNN" to find what happened to it.
PR #29568: Size comparison from 73c327e to bd6d2c1 Increases above 0.2%:
Increases (17 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, nrfconnect, psoc6)
Decreases (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast tracking Darwin-only change. |
…project-chip#29568) * Darwin: Improve MTRAsyncWorkQueue logging by tracking unique item ids Also return more information from the batching handler so we can log both partial and full batching from the queue itself. * Avoid unused variable warning / error * Include work item id in various log messages as per review * Tweaks from review * restyle
Also return more information from the batching handler so we can log both partial and full batching from the queue itself.