-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MTROperationalCredentialsClusterAttestationResponseParams.attestationChallenge on Darwin. #29565
Fix MTROperationalCredentialsClusterAttestationResponseParams.attestationChallenge on Darwin. #29565
Conversation
PR #29565: Size comparison from 73c327e to 62f0399 Full report (14 builds for cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, qpg)
|
62f0399
to
7ca8983
Compare
PR #29565: Size comparison from 73c327e to 7ca8983 Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)
|
d2244de
to
11e340f
Compare
PR #29565: Size comparison from 73c327e to 11e340f Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
11e340f
to
0047916
Compare
PR #29565: Size comparison from 73c327e to 0047916 Full report (1 build for cc32xx)
|
0047916
to
cfdf32d
Compare
PR #29565: Size comparison from 73c327e to cfdf32d Increases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…tionChallenge on Darwin. This got broken because we had no tests. Also makes attestationChallenge work when invoking via the MTRDevice/MTRBaseDevice interface, not just MTRCluster/MTRBaseCluster.
cfdf32d
to
6bb4fd7
Compare
PR #29565: Size comparison from d15daf8 to 6bb4fd7 Decreases (1 build for esp32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp
…tionChallenge on Darwin. (project-chip#29565) This got broken because we had no tests. Also makes attestationChallenge work when invoking via the MTRDevice/MTRBaseDevice interface, not just MTRCluster/MTRBaseCluster.
This got broken because we had no tests.
Also makes attestationChallenge work when invoking via the MTRDevice/MTRBaseDevice interface, not just MTRCluster/MTRBaseCluster.