-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MTRBaseCluster reads/subscribes on top of MTRBaseDevice. #29557
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-read-subscribe-bridging
Oct 12, 2023
Merged
Implement MTRBaseCluster reads/subscribes on top of MTRBaseDevice. #29557
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nix-read-subscribe-bridging
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran and
hawk248
October 4, 2023 06:30
pullapprove
bot
requested review from
turon,
tima-q,
vivien-apple,
tobiasgraf,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
October 4, 2023 06:30
PR #29557: Size comparison from 54a1460 to 0e7de52 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 5, 2023
bzbarsky-apple
force-pushed
the
nix-read-subscribe-bridging
branch
from
October 6, 2023 03:23
0e7de52
to
3a6e626
Compare
PR #29557: Size comparison from d825d51 to 3a6e626 Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Oct 7, 2023
bzbarsky-apple
force-pushed
the
nix-read-subscribe-bridging
branch
from
October 11, 2023 15:33
3a6e626
to
dc2d9b5
Compare
Fast-tracking platform-specific fix with platform owner review. |
PR #29557: Size comparison from 78eb271 to dc2d9b5 Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This significantly reduces the size of the framework and speeds up compilation of MTRBaseClusters.
bzbarsky-apple
force-pushed
the
nix-read-subscribe-bridging
branch
from
October 12, 2023 01:26
dc2d9b5
to
e19516c
Compare
PR #29557: Size comparison from 2a37b68 to e19516c Increases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…roject-chip#29557) This significantly reduces the size of the framework and speeds up compilation of MTRBaseClusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This significantly reduces the size of the framework and speeds up compilation of MTRBaseClusters.