-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chef] Add Robotic Vacuum Cleaner (RVC) device type delegates #29519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
kpschoedel
October 1, 2023 09:05
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 1, 2023 09:05
PR #29519: Size comparison from a40b53c to f1e485d Decreases (1 build for telink)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
erwinpan1
changed the title
Add Chef Robotic Vacuum Cleaner (RVC) device type delegates
[Chef] Add Robotic Vacuum Cleaner (RVC) device type delegates
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
andy31415
approved these changes
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
plauric
approved these changes
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
tehampson
reviewed
Oct 2, 2023
PR #29519: Size comparison from 7013b09 to 814982f Full report (2 builds for cc32xx, mbed)
|
to latest line since the RVC_CLEAN_MODE will use global variable in RVC_RUN_MODE
PR #29519: Size comparison from 7013b09 to 775a54f Full report (4 builds for cc32xx, mbed, qpg)
|
PR #29519: Size comparison from 188cf7d to f196b73 Increases (1 build for telink)
Decreases (2 builds for telink)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…t-chip#29519) * Add Chef RVC device type * Update rootnode_roboticvacuumcleaner_1807ff0c49.matter * Restyled by clang-format * Fix nit in chef-rvc-mode-delegate.* * Rollback previous changes regarding to RvcCleanMode * Move ifdef ZCL_USING_RVC_RUN_MODE_CLUSTER_SERVER to latest line since the RVC_CLEAN_MODE will use global variable in RVC_RUN_MODE --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
chef-rvc-operational-state-delegate.*
andchef-rvc-mode-delegate.*
. Otherwise, we'll not be able to get anything when readingSupportedModes
fromRVC Run Mode Cluster
andRVC Clean Mode Cluster
.Also updated some attributes to
NVM
instead ofexternal
so that they could be written by RPC