-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Convert possible glib objects to GAutoPtr<> #29488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
September 28, 2023 12:55
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
September 28, 2023 12:55
PR #29488: Size comparison from aedf2d5 to 713a27d Full report (15 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
arkq
approved these changes
Sep 28, 2023
DamMicSzm
force-pushed
the
tizen-gautoptr-conv
branch
from
September 28, 2023 13:45
713a27d
to
08a8908
Compare
PR #29488: Size comparison from 3c2a5ed to 08a8908 Decreases (1 build for telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
DamMicSzm
force-pushed
the
tizen-gautoptr-conv
branch
from
September 29, 2023 09:41
08a8908
to
12b964e
Compare
PR #29488: Size comparison from 433e676 to 12b964e Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 29, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Replace glib char with GAutoPtr<char> in BLEManagerImpl.cpp * Replace glib char with GAutoPtr<char> in DnssdImpl.cpp * Replace glib char with GAutoPtr<char> in WiFiManager.cpp * Add GSource to GLibTypeDeleter.h * Replace glib GSource with GAutoPtr<GSource> in ChipDeviceScanner.cpp * Replace glib GSource with GAutoPtr<GSource> in DnssdImpl.cpp * Replace glib GSource with GAutoPtr<GSource> in PlatformManagerImpl.cpp * Review update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tizen still has explicit glib memory management. This is follow-up PRs (#28304) which will replace glib explicit memory management with GAutoPtr<>.
Changes
Changed explicit memory management of glib objects to GAutoPtr<> where possible for the Tizen platform.
Testing
CI will test for potential build breaks.