-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relocate json-related method to TextFormat file #29060
Merged
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/pretty_jsontlv
Oct 16, 2023
Merged
Relocate json-related method to TextFormat file #29060
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/pretty_jsontlv
Oct 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/pretty_jsontlv
branch
from
September 5, 2023 01:36
6543932
to
080ee5b
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
September 5, 2023 01:37
PR #29060: Size comparison from 54038c0 to 080ee5b Increases (1 build for telink)
Decreases (2 builds for efr32, telink)
Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
andy31415
reviewed
Sep 5, 2023
andy31415
reviewed
Sep 5, 2023
yunhanw-google
changed the title
Relocate json-related method to JsonUtilities file
Relocate json-related method to TextFormat file
Sep 5, 2023
PR #29060: Size comparison from 54038c0 to 7b8fa22 Increases (28 builds for bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, psoc6, qpg)
Decreases (11 builds for bl602, bl702, bl702l, esp32, linux)
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
andy31415
approved these changes
Sep 5, 2023
yunhanw-google
force-pushed
the
feature/pretty_jsontlv
branch
from
September 5, 2023 17:49
7b8fa22
to
19db342
Compare
PR #29060: Size comparison from e81a7fe to 19db342 Decreases (1 build for efr32)
Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Sep 5, 2023
PR #29060: Size comparison from e81a7fe to b0080a2 Full report (2 builds for cc32xx, mbed)
|
PR #29060: Size comparison from e81a7fe to 709348a Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/pretty_jsontlv
branch
from
October 16, 2023 17:02
709348a
to
cba1073
Compare
bzbarsky-apple
approved these changes
Oct 16, 2023
PR #29060: Size comparison from 3437b59 to cba1073 Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Relocate json-related method to JsonUtilities file * address comment * address comment * Restyled by gn * removed unused and broken MakeJsonSingleLine --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes, #28386
In src/lib/support/jsontlv/TlvToJson.h, there two methods to pretty-print Json strings: PrettyPrintJsonString(), which are not related to TLV, it is better to relocate them to dedicate TextFormat file.
Remove broken MakeJsonSingleLine.