[Tizen] Update Tizen SDK to the latest version #28765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
Looking at https://github.com/project-chip/connectedhomeip/blob/master/integrations/docker/images/stage-2/chip-build-tizen/tizen-sdk-installer/install.sh#L224 it may be that this build is not reproducible ... that is bad: it means that if I ever need to re-build an image for any reason (for example we needed to move from dockerhub to github packages) then a re-build may not be the same as an old build and changes are silent. Can we somehow make the build scripts used fixed versions (tags/hashes/urls)? |
Using fixed version might also be tricky. As far as I know (@dh79pyun please correct me if I'm wrong), packages on download.tizen.org/snapshots/TIZEN, which now contains new version of one of packages, are purged when out of date. So, if one would like to rebuild docker with fixed version in few months or so, the build might fail because package versions have changed. The problem is that we are using pre-release version of Tizen (like a development branch), and this version is not stored permanently in package antifactory (it would be a ton of data, since new platform snapshot - all packages - is made every few days). So, the current approach is to download packages in a wildcard way, so every time a package in the download.tizen.org is changed, it will not cause build break for connectedhomeip project... |
|
For what its worth, we updated to version 9 because other changes ... but tizen being updated as a sideffect is probably unexpected. I see we glob some of the libraries, so maybe that could be a placeholder instead of |
The maintenance overhead might be huge... If we'd like to pin to a specific version of snapshot (not the "latest" which is a symlink to the last snapshot), we will have to update this script every week or so... See this: https://download.tizen.org/snapshots/TIZEN/Tizen/Tizen-Unified/ That's the list of available snapshots. Older versions are purged. |
Actually, Tizen Matter SDK installer fetches Tizen packages using 2 method.
In the normal case, even if,, tizen's devel branch. The Tizen API must ensure the backward compatibility. So, there is no risk of build error cause of Tizen SDK's modification. In later. 2. Changable package can move the fixed base packages.
|
dh79pyun
force-pushed
the
update_tizen_docker
branch
from
a34ec39 to
496ea5a
Compare
Tizen 8.0 SDK will be released on 2023 Oct officially. In that time, the fixed URL will create And I will be able to do it the way you suggested. (Use fixed URL) |
dh79pyun
changed the title
|
Updated the docker image by next PR. So we don't need to up the version using this PR. |
dh79pyun
changed the title
dh79pyun
force-pushed
the
update_tizen_docker
branch
from
29a56aa to
37ba165
Compare
|
PR #28765: Size comparison from 684b9d6 to 37ba165 Increases (2 builds for telink)
Decreases (1 build for efr32)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 23, 2023
Tizen SDK's thread API was modified caused by the opensource change. Tizen SDK change was applied on tizen-unified_20230816.124244. And we should use the tizen docker to use the version after it.
dh79pyun
force-pushed
the
update_tizen_docker
branch
from
37ba165 to
19f5a61
Compare
|
PR #28765: Size comparison from 5532798 to 19f5a61 Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Tizen image updated in the mean time and this PR is 1 year old. Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tizen docker fetches the latest SDK's modification, and it effects on the example build.
ot-br-posix's dbus method change was applied in Tizen SDK 20230816 version,
openthread/ot-br-posix#1814
And it should be applied the tizen docker image.