Time sync: add check for fabric removal #28011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
arkq
approved these changes
Jul 18, 2023
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
woody-apple
approved these changes
Jul 18, 2023
cecille
commented
Jul 18, 2023
src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Outdated
Show resolved
Hide resolved
| @@ -258,6 +258,13 @@ void TimeSynchronizationServer::Init() | |||
| { | |||
| mGranularity = GranularityEnum::kNoTimeGranularity; | |||
| } | |||
| // This can error, but it's not clear what should happen in this case. For now, just ignore it because we still | |||
| // want time sync even if we can't register the deletgate here. | |||
| CHIP_ERROR err = chip::Server::GetInstance().GetFabricTable().AddFabricDelegate(this); | |||
There was a problem hiding this comment.
Should we not RemoveFabricdDelegate on shutdown, or at worst in the destructor?
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Time sync: add check for fabric removal * Update src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: tested against cert test TC-TIMESYNC-2.13 implemented in #27917