Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of already commissioned device in TC_DeviceBasicComposition #27919

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Allow use of already commissioned device in TC_DeviceBasicComposition #27919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/python_testing/TC_DeviceBasicComposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ async def setup_class(self):
dev_ctrl = self.default_controller
self.problems = []

# TODO: Handle already commissioned devices and add argument to specify "let's do PASE"
do_test_over_pase = self.user_params.get("use_pase_only", True)
dump_device_composition_path: Optional[str] = self.user_params.get("dump_device_composition_path", None)

Expand Down Expand Up @@ -213,7 +212,8 @@ async def setup_class(self):
else:
asserts.fail("Failed to find the DUT according to command line arguments.")
else:
asserts.fail("TODO: Support testing on already commissioned devices")
# Using the already commissioned node
node_id = self.dut_node_id

wildcard_read = (await dev_ctrl.Read(node_id, [()]))
endpoints_tlv = wildcard_read.tlvAttributes
Expand Down