-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DFT xcodebuild, add preprocces flag, and add discover files to DFT project. #27442
Merged
mergify
merged 2 commits into
project-chip:master
from
krypton36:AddFlagAndDiscoverFilesToDFT
Jun 24, 2023
Merged
Enable DFT xcodebuild, add preprocces flag, and add discover files to DFT project. #27442
mergify
merged 2 commits into
project-chip:master
from
krypton36:AddFlagAndDiscoverFilesToDFT
Jun 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
June 23, 2023 19:07
pullapprove
bot
requested review from
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 23, 2023 19:07
krypton36
force-pushed
the
AddFlagAndDiscoverFilesToDFT
branch
from
June 23, 2023 19:07
b05c974
to
906bfab
Compare
PR #27442: Size comparison from 1a2053f to 906bfab Increases (1 build for cc32xx)
Decreases (2 builds for bl702)
Full report (20 builds for bl602, bl702, cc32xx, efr32, k32w, linux, mbed, nrfconnect, qpg)
|
krypton36
force-pushed
the
AddFlagAndDiscoverFilesToDFT
branch
from
June 23, 2023 19:59
906bfab
to
562c915
Compare
PR #27442: Size comparison from 1a2053f to 562c915 Increases (2 builds for nrfconnect, psoc6)
Decreases (4 builds for bl702, psoc6, qpg)
Full report (30 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
krypton36
force-pushed
the
AddFlagAndDiscoverFilesToDFT
branch
from
June 23, 2023 21:25
562c915
to
f74cf16
Compare
PR #27442: Size comparison from 42cf63b to f74cf16 Increases (1 build for bl702)
Decreases (1 build for bl602)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
krypton36
force-pushed
the
AddFlagAndDiscoverFilesToDFT
branch
from
June 23, 2023 22:12
f74cf16
to
83dd6f5
Compare
PR #27442: Size comparison from 42cf63b to 83dd6f5 Increases (8 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (8 builds for bl602, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #27442: Size comparison from 42cf63b to 5e1df7c Increases (9 builds for bl602, esp32, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc32xx, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
DFT was not compiling in Xcode.