Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Improve BLE scan logging #25817

Merged
merged 3 commits into from
Mar 25, 2023
Merged

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Mar 24, 2023

Problem

BLE scan logs non-error level messages as error. Also, it does not show error reason, but bare numbers which are hard to decipher.

Changes

  • use System::Clock::Timeout for timeout
  • do not report progress messages as error
  • convert error code to message when printing logs
  • check BLE scan filter support with proper Tizen API

Testing

Tested locally with:

dlogutil CHIP &
/opt/usr/apps/chip-tool pairing ble-wifi 1 <SSID> <pass> 20202021 3840

@github-actions
Copy link

PR #25817: Size comparison from a4a407b to b3e3433

Decreases (1 build for cc32xx)
platform target config section a4a407b b3e3433 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20229260 20229259 -1 -0.0
Full report (1 build for cc32xx)
platform target config section a4a407b b3e3433 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645825 645825 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930266 930266 0 0.0
.debug_aranges 87376 87376 0 0.0
.debug_frame 300288 300288 0 0.0
.debug_info 20229260 20229259 -1 -0.0
.debug_line 2661728 2661728 0 0.0
.debug_loc 2806516 2806516 0 0.0
.debug_ranges 283400 283400 0 0.0
.debug_str 3028246 3028246 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380469 380469 0 0.0
.symtab 257408 257408 0 0.0
.text 537712 537712 0 0.0

Copy link
Contributor

@jlatusek jlatusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested locally and works fine.

@andy31415 andy31415 merged commit ec2ad41 into project-chip:master Mar 25, 2023
@arkq arkq deleted the tizen-ble-scan branch March 25, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants