Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase strictness of error that are raised by chip-repl runner/adapter #25357

Merged

Conversation

tehampson
Copy link
Contributor

This addressed 2 issues:

  • The name change from ParsingError to ActionCreationError is to better represent the error we are raising.
  • Now that chip-repl runner/adapter functionality has reached parity with codegen capabilities it is time to have stricter errorring so test no longer silently fail.

@pullapprove pullapprove bot requested a review from sharadb-amazon February 27, 2023 22:24
@github-actions
Copy link

PR #25357: Size comparison from e807d2d to 4af515c

Decreases (1 build for cc32xx)
platform target config section e807d2d 4af515c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256131 20256130 -1 -0.0
Full report (1 build for cc32xx)
platform target config section e807d2d 4af515c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642601 642601 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930126 930126 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299812 299812 0 0.0
.debug_info 20256131 20256130 -1 -0.0
.debug_line 2656120 2656120 0 0.0
.debug_loc 2797440 2797440 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023104 3023104 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105761 105761 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256224 256224 0 0.0
.text 534716 534716 0 0.0

@tehampson tehampson merged commit 4dd9eda into project-chip:master Feb 28, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…ter (project-chip#25357)

* Increase strictness of error that are raised

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants