Update Pigweed; switch tokenized logging to its own handler function #25351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
255
force-pushed
the
tokenized_logging_api
branch
4 times, most recently
from
644fa65 to
dadde78
Compare
|
PR #25351: Size comparison from 11c2f5b to dadde78 Decreases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
255
force-pushed
the
tokenized_logging_api
branch
from
dadde78 to
f32d321
Compare
|
PR #25351: Size comparison from d44b6a6 to f32d321 Full report (1 build for cc32xx)
|
255
force-pushed
the
tokenized_logging_api
branch
from
f32d321 to
efc6100
Compare
255
changed the title
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha and
franck-apple
255
changed the title
msandstedt
approved these changes
Mar 21, 2023
255
force-pushed
the
tokenized_logging_api
branch
2 times, most recently
from
c5d4181 to
a291d96
Compare
|
PR #25351: Size comparison from 78df209 to a291d96 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
andy31415
approved these changes
Apr 7, 2023
|
PR #25351: Size comparison from 78df209 to fbc392c Increases above 0.2%:
Increases (20 builds for bl602, bl702, cc32xx, cyw30739, efr32, mbed, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, bl702, k32w, mbed, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
255
force-pushed
the
tokenized_logging_api
branch
from
fbc392c to
35298cd
Compare
Specify a linker search directory (-L) for pw_tokenizer's linker script, since an upcoming Pigweed commit splits the linker script into two files.
This commit updates the Pigweed submodule to 73cac22f, which requires some changes. Pigweed's pw_tokenizer:global_handler_with_payload facade is deprecated. Each pw_tokenizer should define its own handler function instead. This gives each pw_tokenizer user more control over the handler function and allows multiple subsystems to use pw_tokenizer in whichever way works best. This change updates the tokenized version of the ChipInternalLogImpl macro to function as described at https://pigweed.dev/pw_tokenizer/#tokenize-a-message-with-arguments-in-a-custom-macro.
255
force-pushed
the
tokenized_logging_api
branch
from
35298cd to
724bd8a
Compare
|
PR #25351: Size comparison from 6eded52 to 724bd8a Increases above 0.2%:
Increases (5 builds for bl602, bl702, cyw30739, psoc6)
Decreases (6 builds for bl602, bl702, cc32xx, nrfconnect, psoc6)
Full report (26 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg)
|
|
This PR is ready to merge. I don't have merge permissions, though, so feel free to merge for me if you do. |
marius-alex-tache
added a commit
to NXP/matter
that referenced
this pull request
Apr 27, 2023
Issue introduced in: project-chip#25351 Encoded message should also contain the token. Signed-off-by: Marius Tache <[email protected]>
bzbarsky-apple
pushed a commit
that referenced
this pull request
Apr 29, 2023
Issue introduced in: #25351 Encoded message should also contain the token. Signed-off-by: Marius Tache <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pigweed's pw_tokenizer:global_handler_with_payload facade is deprecated. Each pw_tokenizer should define its own handler function instead.
This gives each pw_tokenizer user more control over the handler function and allows multiple subsystems to use pw_tokenizer in whichever way works best.