Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ linux cirque ] Add flake8 to workflow and fix python files (part #25193) #25245

Merged
merged 3 commits into from
May 2, 2023
Merged

[ linux cirque ] Add flake8 to workflow and fix python files (part #25193) #25245

merged 3 commits into from
May 2, 2023

Conversation

DamMicSzm
Copy link
Contributor

This pull request is a part of #25193 ( part fix python files in src/test_driver/linux-cirque )

Problem

Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.

Changes

Fix all python files in cirque linux test where linter find problem.

Testing

CI will test and maybe some another manual testing

@github-actions
Copy link

PR #25245: Size comparison from 9f3a468 to 6d00898

Increases (1 build for cc32xx)
platform target config section 9f3a468 6d00898 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_line 2655143 2655149 6 0.0
Full report (1 build for cc32xx)
platform target config section 9f3a468 6d00898 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642545 642545 0 0.0
(read/write) 203664 203664 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197064 197064 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930168 930168 0 0.0
.debug_aranges 87272 87272 0 0.0
.debug_frame 299752 299752 0 0.0
.debug_info 20254059 20254059 0 0.0
.debug_line 2655143 2655149 6 0.0
.debug_loc 2795383 2795383 0 0.0
.debug_ranges 281592 281592 0 0.0
.debug_str 3017876 3017876 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105817 105817 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377610 377610 0 0.0
.symtab 256144 256144 0 0.0
.text 534604 534604 0 0.0

@bzbarsky-apple
Copy link
Contributor

@yunhanw-google

@DamMicSzm DamMicSzm force-pushed the flake8-fix-linux-cirque branch from 6d00898 to b9c4104 Compare February 24, 2023 09:35
@github-actions
Copy link

PR #25245: Size comparison from 61cf6f2 to b9c4104

Increases (1 build for cc32xx)
platform target config section 61cf6f2 b9c4104 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20257009 20257010 1 0.0
Full report (1 build for cc32xx)
platform target config section 61cf6f2 b9c4104 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930133 930133 0 0.0
.debug_aranges 87304 87304 0 0.0
.debug_frame 299872 299872 0 0.0
.debug_info 20257009 20257010 1 0.0
.debug_line 2656183 2656183 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281792 281792 0 0.0
.debug_str 3023459 3023459 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@github-actions
Copy link

PR #25245: Size comparison from 31da720 to c7d49a1

Decreases (1 build for cc32xx)
platform target config section 31da720 c7d49a1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256908 20256906 -2 -0.0
Full report (1 build for cc32xx)
platform target config section 31da720 c7d49a1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256908 20256906 -2 -0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-linux-cirque branch from c7d49a1 to 4267f76 Compare February 28, 2023 09:44
@pullapprove pullapprove bot requested a review from sharadb-amazon February 28, 2023 09:44
@github-actions
Copy link

PR #25245: Size comparison from 92d86d5 to 4267f76

Full report (1 build for cc32xx)
platform target config section 92d86d5 4267f76 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643073 643073 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930155 930155 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299824 299824 0 0.0
.debug_info 20261985 20261985 0 0.0
.debug_line 2657104 2657104 0 0.0
.debug_loc 2799620 2799620 0 0.0
.debug_ranges 282184 282184 0 0.0
.debug_str 3023185 3023185 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105889 105889 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256240 256240 0 0.0
.text 535060 535060 0 0.0

@DamMicSzm DamMicSzm force-pushed the flake8-fix-linux-cirque branch from 4267f76 to 960459a Compare March 1, 2023 09:46
@pullapprove pullapprove bot requested a review from cliffamzn March 1, 2023 09:47
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25245: Size comparison from eff5773 to 960459a

Full report (4 builds for cc32xx, mbed, qpg)
platform target config section eff5773 960459a change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930167 930167 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 20262893 20262893 0 0.0
.debug_line 2657207 2657207 0 0.0
.debug_loc 2799993 2799993 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467448 2467448 0 0.0
.bss 215804 215804 0 0.0
.data 5880 5880 0 0.0
.text 1430092 1430092 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151668 1151668 0 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598764 598764 0 0.0
lock-app qpg6105+debug (read/write) 1118876 1118876 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565976 565976 0 0.0

@pullapprove pullapprove bot requested review from joonhaengHeo and younghak-hwang and removed request for pjzander-signify March 14, 2023 17:35
@DamMicSzm DamMicSzm force-pushed the flake8-fix-linux-cirque branch from 960459a to 290d2c5 Compare April 17, 2023 12:03
@github-actions
Copy link

PR #25245: Size comparison from 3037a8a to 290d2c5

Full report (1 build for cc32xx)
platform target config section 3037a8a 290d2c5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643249 643249 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87792 87792 0 0.0
.debug_frame 302140 302140 0 0.0
.debug_info 20328411 20328411 0 0.0
.debug_line 2687890 2687890 0 0.0
.debug_loc 2838930 2838930 0 0.0
.debug_ranges 288072 288072 0 0.0
.debug_str 3042155 3042155 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104401 104401 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377963 377963 0 0.0
.symtab 256976 256976 0 0.0
.text 536728 536728 0 0.0

@github-actions
Copy link

PR #25245: Size comparison from 29f0d36 to 95fcc40

Increases (1 build for cc32xx)
platform target config section 29f0d36 95fcc40 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19522047 19522048 1 0.0
Full report (1 build for cc32xx)
platform target config section 29f0d36 95fcc40 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 602722 602722 0 0.0
(read/write) 204156 204156 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197568 197568 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956996 956996 0 0.0
.debug_aranges 103664 103664 0 0.0
.debug_frame 350552 350552 0 0.0
.debug_info 19522047 19522048 1 0.0
.debug_line 2682783 2682783 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1506228 1506228 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96278 96278 0 0.0
.debug_str 3059509 3059509 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104250 104250 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 481887 481887 0 0.0
.symtab 287248 287248 0 0.0
.text 496348 496348 0 0.0

@andy31415 andy31415 merged commit 8f66f42 into project-chip:master May 2, 2023
@arkq arkq deleted the flake8-fix-linux-cirque branch May 2, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@arkq arkq arkq approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
review - approved test driver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DamMicSzm @bzbarsky-apple @arkq @Damian-Nordic @andy31415 @restyled-commits