-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "DiscoveryCommands" to yaml repl tests, make TestDiscovery.yaml
pass
#24763
Merged
andy31415
merged 14 commits into
project-chip:master
from
andy31415:discover_commissionable
Feb 2, 2023
Merged
Add "DiscoveryCommands" to yaml repl tests, make TestDiscovery.yaml
pass
#24763
andy31415
merged 14 commits into
project-chip:master
from
andy31415:discover_commissionable
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24763: Size comparison from f951fa9 to aee91aa Increases (11 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
commented
Jan 31, 2023
andy31415
changed the title
Start adding 'DiscoveryCommands' pseudo cluster implementation in repl-yaml tests
Add "DiscoveryCommands" to yaml repl tests, make Jan 31, 2023
TestDiscovery.yaml
pass
PR #24763: Size comparison from f951fa9 to c9d14d4 Increases (16 builds for bl602, bl702, cc13x2_26x2, efr32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for bl702, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
February 1, 2023 00:48
pullapprove
bot
requested review from
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
February 1, 2023 00:48
bzbarsky-apple
approved these changes
Feb 1, 2023
21 tasks
PR #24763: Size comparison from 25df49b to 08aa76d Increases (7 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Feb 1, 2023
PR #24763: Size comparison from 25df49b to 7c6ea9e Increases (7 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 1, 2023
PR #24763: Size comparison from fa8fa15 to 8b34708 Increases (1 build for bl602)
Decreases (1 build for bl702)
Full report (10 builds for bl602, bl702, k32w, mbed, qpg)
|
PR #24763: Size comparison from fa8fa15 to 7655c70 Increases (8 builds for bl602, cc13x2_26x2, efr32, linux, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, efr32, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24763: Size comparison from fa8fa15 to 816fcf3 Increases (16 builds for bl602, bl702, cc13x2_26x2, efr32, k32w, linux, psoc6, telink)
Decreases (23 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, k32w, linux, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
… pass (project-chip#24763) * Make discoverCommissionable work for now. More items to follow * TestDiscovery now passes * Minor update because short discriminator was wrong before * Stop trying to auto-cast short discriminator in discovery commands * Undo minmdns high verbosity * Restyle * Disable Test_TC_OO_2_4 * Set filter for MC to none (not needed) * Update after review comments * Update double-disable of flaky test... separating flaky from todo * Undo restyle only change * Make Test flaky instead of failing ... since it seems sometimes it may pass --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a working 'FindCommissionable' implementation (that does assume a single result!).
Also updated:
not yet implemented
action