-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add support for unordered commands/attributes arguments formatted a… #24386
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_UnorderedArguments
Jan 23, 2023
Merged
[chip-tool] Add support for unordered commands/attributes arguments formatted a… #24386
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_UnorderedArguments
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
January 12, 2023 18:10
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 12, 2023 18:10
vivien-apple
changed the title
[chip-tool] Add support for commands/attributes arguments formatted a…
[chip-tool] Add support for unordered commands/attributes arguments formatted a…
Jan 12, 2023
PR #24386: Size comparison from 3670731 to f2633d1 Increases above 0.2%:
Increases (9 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 14, 2023
bzbarsky-apple
requested changes
Jan 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, meant to request changes, for the off-the-end-of-the-array bit.
vivien-apple
force-pushed
the
ChipTool_UnorderedArguments
branch
from
January 17, 2023 14:44
f2633d1
to
161e872
Compare
PR #24386: Size comparison from 9fbcf1c to 161e872 Increases above 0.2%:
Increases (8 builds for bl702, cc13x2_26x2, linux, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 17, 2023
andy31415
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s json
Problem
chip-tool
now supports simple commands over web socket (e.gonoff toggle 0x12344321 1
) but for commands that are more complex, the client does not necessarily know the arguments ordering.Additional some arguments can not be passed over the wire as simple strings since they may contains control characters and notable
\0
.This PR adds some supports to
chip-tool
to handle unordered commands over web sockets.I have also updated the code such that
examples/chip-tool/commands/common/Commands.cpp
is now responsible for parsing "all" interactive commands - which avoid duplicating some code betweenchip-tool
anddarwin-framework-tool
.