[crypto] Added target type to the P256KeyPair initialize method #23771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the crypto PAL implementations, like PSA require information about the target usage algoritm for the key at the moment of its generation. Current P256KeyPair API doesn't allow to pass such information Summary of changes: * Added target enum type to P256KeyPair Initialize() method * Aligned all places that Initialize() is invoked to pass ECDSA or ECDH (basically only for the CASE) type. * In CryptoPALPSA implementation removed method converting ECDSA to ECDH key and added generating ECDH or ECDSA key in the Initialize() method based on passed target.
github-actions
bot
added
controller
crypto
darwin
examples
platform
tools
transport
labels
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
pullapprove
bot
added
review - pending
controller
crypto
darwin
examples
platform
tools
transport
and removed
tools
examples
transport
platform
darwin
crypto
controller
labels
|
PR #23771: Size comparison from 87994ad to 581993c Increases (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for cc13x2_26x2, psoc6)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LuDuda
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the crypto PAL implementations, like PSA require information about the target usage algoritm for the key at the moment of its generation. Current
P256KeyPairAPI doesn't allow to pass such informationSummary of changes:
Initialize()methodInitialize()is invoked to pass ECDSA or ECDH (basically only for the CASE) type.CryptoPALPSAimplementation removed method converting ECDSA to ECDH key and added generating ECDH or ECDSA key in theInitialize()method based on passed target.Tests: Verified manually that PASE and CASE works between nrfconnect platform (using CryptoPALPSA implementation) and chiptool, and also that CHIPCryptoPAL unit tests pass.