Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct operational certs access from FabricInfo #19531

Merged
merged 8 commits into from
Jun 13, 2022
Merged

Remove direct operational certs access from FabricInfo #19531

merged 8 commits into from
Jun 13, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

To support moving to non-permanent storage, need to ensure
there is never direct access to certificates from FabricInfo classes
outside the FabricTable which owns all validations. This prevents
dangling FabricInfo instances and enables the changes needed to
make the fail-safe work to spec for AddNOC, UpdateNOC and
AddTrustedRootCertificate.

Issue #15585
Issue #7695

Change overview

  • Always go through the FabricTable, don't allow going directly via
    FabricInfo
  • Updated CASESession to go through FabricTable also
  • Getters for certs and root public key are now copying operations,
    rather than updating a ByteSpan to internally owned data (which
    may be stale!)
  • First step towards moving to spec-compliant lifecycle for UpdateNOC
    with the same model as OperationalKeystore
  • No functional changes, only structural changes

Testing

  • Cert tests still pass
  • Unit tests still pass

@tcarmelveilleux
Remove direct operational certs access from FabricInfo
0952ad5 
To support moving to non-permanent storage, need to ensure
there is never direct access to certificates from FabricInfo classes
outside the FabricTable which owns all validations. This prevents
dangling FabricInfo instances and enables the changes needed to
make the fail-safe work to spec for AddNOC, UpdateNOC and
AddTrustedRootCertificate.

Issue project-chip#15585
Issue project-chip#7695

- Always go through the FabricTable, don't allow going directly via
  FabricInfo
- Updated CASESession to go through FabricTable also
- Getters for certs and root public key are now copying operations,
  rather than updating a ByteSpan to internally owned data (which
  may be stale!)
- First step towards moving to spec-compliant lifecycle for UpdateNOC
  with the same model as OperationalKeystore
- No functional changes, only structural changes

Testing done:
- Cert tests still pass
- Unit tests still pass
@restyled-io restyled-io bot mentioned this pull request Jun 13, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19531: Size comparison from 0e9b2cc to 0952ad5

Increases (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc 0952ad5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658983 688 0.1
.text 570960 571648 688 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645515 680 0.1
.text 554480 555160 680 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688379 672 0.1
.text 588364 589036 672 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637787 672 0.1
.text 537884 538556 672 0.1
pump-app LP_CC2652R7 (read only) 669083 669779 696 0.1
.text 581620 582316 696 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660335 680 0.1
.text 574292 574972 680 0.1
shell LP_CC2652R7 (read only) 688446 689126 680 0.1
.text 578040 578720 680 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607218 656 0.1
.app_xip_area 465060 465716 656 0.1
lock cyw930739m2evb_01 (read/write) 603678 604334 656 0.1
.app_xip_area 462032 462688 656 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612062 680 0.1
.app_xip_area 470808 471488 680 0.1
k32w light k32w061+release (read/write) 657248 657904 656 0.1
.text 579672 580328 656 0.1
lock k32w061+release (read/write) 718860 719532 672 0.1
.text 640880 641552 672 0.1
linux all-clusters-app debug (read only) 2923761 2925505 1744 0.1
.text 2489906 2491650 1744 0.1
all-clusters-minimal-app debug (read only) 2769193 2770937 1744 0.1
.text 2337458 2339202 1744 0.1
bridge-app debug+rpc (read only) 2247553 2250337 2784 0.1
.rodata 191040 191072 32 0.0
.text 1896530 1899282 2752 0.1
chip-tool debug (read only) 9815973 9818021 2048 0.0
.text 7868549 7870597 2048 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565372 1512 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520468 1488 0.0
lighting-app debug+rpc (read only) 2497465 2499801 2336 0.1
.rodata 207144 207176 32 0.0
.text 2122130 2124434 2304 0.1
lock-app debug (read only) 2443465 2445769 2304 0.1
.text 2059074 2061378 2304 0.1
ota-provider-app debug (read only) 2281729 2284321 2592 0.1
.rodata 197336 197368 32 0.0
.text 1923202 1925762 2560 0.1
ota-requestor-app debug (read only) 2329289 2331881 2592 0.1
.rodata 199520 199552 32 0.0
.text 1964738 1967298 2560 0.1
shell debug (read only) 2604841 2606617 1776 0.1
.rodata 229778 229810 32 0.0
.text 2215746 2217490 1744 0.1
thermostat-no-ble arm64 (read only) 2557916 2559524 1608 0.1
.rodata 161332 161356 24 0.0
.text 2158912 2160496 1584 0.1
tv-app debug (read only) 3050873 3053785 2912 0.1
.text 2622370 2625282 2912 0.1
tv-casting-app debug (read only) 5349977 5351721 1744 0.0
.text 4656338 4658082 1744 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2432808 2433680 872 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198971 656 0.1
text 821652 822300 648 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144187 656 0.1
text 791972 792620 648 0.1
p6 all-clusters-app default (read/write) 2551672 2552600 928 0.0
.text 1509936 1510864 928 0.1
all-clusters-minimal-app default (read/write) 2494128 2495056 928 0.0
.text 1452392 1453320 928 0.1
light-app default (read/write) 2425560 2426472 912 0.0
.text 1383824 1384736 912 0.1
lock-app default (read/write) 2445968 2446896 928 0.0
.text 1404232 1405160 928 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787660 936 0.1
text 556634 557572 938 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807640 936 0.1
text 573328 574262 934 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section 0e9b2cc 0952ad5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192592 191904 -688 -0.4
lock-ftd LP_CC2652R7 (read/write) 154252 153580 -672 -0.4
pump-app LP_CC2652R7 (read/write) 173788 173092 -696 -0.4
pump-controller-app LP_CC2652R7 (read/write) 183320 182640 -680 -0.4
shell LP_CC2652R7 (read/write) 157936 157256 -680 -0.4
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc 0952ad5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658983 688 0.1
(read/write) 192592 191904 -688 -0.4
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 87023 87023 0 0.0
.text 570960 571648 688 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645515 680 0.1
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 555160 680 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688379 672 0.1
(read/write) 154252 153580 -672 -0.4
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 589036 672 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637787 672 0.1
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 538556 672 0.1
pump-app LP_CC2652R7 (read only) 669083 669779 696 0.1
(read/write) 173788 173092 -696 -0.4
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 582316 696 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660335 680 0.1
(read/write) 183320 182640 -680 -0.4
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574972 680 0.1
shell LP_CC2652R7 (read only) 688446 689126 680 0.1
(read/write) 157936 157256 -680 -0.4
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 110094 110094 0 0.0
.text 578040 578720 680 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607218 656 0.1
.app_xip_area 465060 465716 656 0.1
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 604334 656 0.1
.app_xip_area 462032 462688 656 0.1
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612062 680 0.1
.app_xip_area 470808 471488 680 0.1
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657248 657904 656 0.1
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579672 580328 656 0.1
lock k32w061+release (read/write) 718860 719532 672 0.1
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 641552 672 0.1
linux all-clusters-app debug (read only) 2923761 2925505 1744 0.1
(read/write) 188528 188528 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84488 84488 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2489906 2491650 1744 0.1
all-clusters-minimal-app debug (read only) 2769193 2770937 1744 0.1
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2337458 2339202 1744 0.1
bridge-app debug+rpc (read only) 2247553 2250337 2784 0.1
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 191072 32 0.0
.text 1896530 1899282 2752 0.1
chip-tool debug (read only) 9815973 9818021 2048 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7870597 2048 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565372 1512 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520468 1488 0.0
lighting-app debug+rpc (read only) 2497465 2499801 2336 0.1
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 207176 32 0.0
.text 2122130 2124434 2304 0.1
lock-app debug (read only) 2443465 2445769 2304 0.1
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 221192 0 0.0
.text 2059074 2061378 2304 0.1
ota-provider-app debug (read only) 2281729 2284321 2592 0.1
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 197368 32 0.0
.text 1923202 1925762 2560 0.1
ota-requestor-app debug (read only) 2329289 2331881 2592 0.1
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 199552 32 0.0
.text 1964738 1967298 2560 0.1
shell debug (read only) 2604841 2606617 1776 0.1
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229810 32 0.0
.text 2215746 2217490 1744 0.1
thermostat-no-ble arm64 (read only) 2557916 2559524 1608 0.1
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 161356 24 0.0
.text 2158912 2160496 1584 0.1
tv-app debug (read only) 3050873 3053785 2912 0.1
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 242720 0 0.0
.text 2622370 2625282 2912 0.1
tv-casting-app debug (read only) 5349977 5351721 1744 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 342368 0 0.0
.text 4656338 4658082 1744 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2433680 872 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198971 656 0.1
bss 141617 141617 0 0.0
rodata 156100 156100 0 0.0
text 821652 822300 648 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144187 656 0.1
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 792620 648 0.1
p6 all-clusters-app default (read/write) 2551672 2552600 928 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1509936 1510864 928 0.1
all-clusters-minimal-app default (read/write) 2494128 2495056 928 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1453320 928 0.1
light-app default (read/write) 2425560 2426472 912 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383824 1384736 912 0.1
lock-app default (read/write) 2445968 2446896 928 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1405160 928 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787660 936 0.1
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556634 557572 938 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807640 936 0.1
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573328 574262 934 0.2

@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19531: Size comparison from 0e9b2cc to d956b35

Increases (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc d956b35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658999 704 0.1
.text 570960 571664 704 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645531 696 0.1
.text 554480 555176 696 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688387 680 0.1
.text 588364 589044 680 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637795 680 0.1
.text 537884 538564 680 0.1
pump-app LP_CC2652R7 (read only) 669083 669795 712 0.1
.text 581620 582332 712 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660351 696 0.1
.text 574292 574988 696 0.1
shell LP_CC2652R7 (read only) 688446 689142 696 0.1
.text 578040 578736 696 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607234 672 0.1
.app_xip_area 465060 465732 672 0.1
lock cyw930739m2evb_01 (read/write) 603678 604350 672 0.1
.app_xip_area 462032 462704 672 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612078 696 0.1
.app_xip_area 470808 471504 696 0.1
k32w light k32w061+release (read/write) 657248 657920 672 0.1
.text 579672 580344 672 0.1
lock k32w061+release (read/write) 718860 719548 688 0.1
.text 640880 641568 688 0.1
linux all-clusters-app debug (read only) 2923761 2925585 1824 0.1
.text 2489906 2491730 1824 0.1
all-clusters-minimal-app debug (read only) 2769193 2771017 1824 0.1
.text 2337458 2339282 1824 0.1
bridge-app debug+rpc (read only) 2247553 2250417 2864 0.1
.rodata 191040 191072 32 0.0
.text 1896530 1899362 2832 0.1
chip-tool debug (read only) 9815973 9818085 2112 0.0
.text 7868549 7870661 2112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499865 2400 0.1
.rodata 207144 207176 32 0.0
.text 2122130 2124498 2368 0.1
lock-app debug (read only) 2443465 2445849 2384 0.1
.text 2059074 2061458 2384 0.1
ota-provider-app debug (read only) 2281729 2284401 2672 0.1
.rodata 197336 197368 32 0.0
.text 1923202 1925842 2640 0.1
ota-requestor-app debug (read only) 2329289 2331961 2672 0.1
.rodata 199520 199552 32 0.0
.text 1964738 1967378 2640 0.1
shell debug (read only) 2604841 2606697 1856 0.1
.rodata 229778 229810 32 0.0
.text 2215746 2217570 1824 0.1
thermostat-no-ble arm64 (read only) 2557916 2559572 1656 0.1
.rodata 161332 161356 24 0.0
.text 2158912 2160544 1632 0.1
tv-app debug (read only) 3050873 3053849 2976 0.1
.text 2622370 2625346 2976 0.1
tv-casting-app debug (read only) 5349977 5351801 1824 0.0
.text 4656338 4658162 1824 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2432808 2433680 872 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198987 672 0.1
text 821652 822320 668 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144203 672 0.1
text 791972 792640 668 0.1
p6 all-clusters-app default (read/write) 2551672 2552616 944 0.0
.text 1509936 1510880 944 0.1
all-clusters-minimal-app default (read/write) 2494128 2495072 944 0.0
.text 1452392 1453336 944 0.1
light-app default (read/write) 2425560 2426504 944 0.0
.text 1383824 1384768 944 0.1
lock-app default (read/write) 2445968 2446912 944 0.0
.text 1404232 1405176 944 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787676 952 0.1
text 556634 557586 952 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807656 952 0.1
text 573328 574276 948 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section 0e9b2cc d956b35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192592 191888 -704 -0.4
lock-ftd LP_CC2652R7 (read/write) 154252 153572 -680 -0.4
pump-app LP_CC2652R7 (read/write) 173788 173076 -712 -0.4
pump-controller-app LP_CC2652R7 (read/write) 183320 182624 -696 -0.4
shell LP_CC2652R7 (read/write) 157936 157240 -696 -0.4
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc d956b35 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658999 704 0.1
(read/write) 192592 191888 -704 -0.4
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 87023 87023 0 0.0
.text 570960 571664 704 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645531 696 0.1
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 555176 696 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688387 680 0.1
(read/write) 154252 153572 -680 -0.4
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 589044 680 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637795 680 0.1
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 538564 680 0.1
pump-app LP_CC2652R7 (read only) 669083 669795 712 0.1
(read/write) 173788 173076 -712 -0.4
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 582332 712 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660351 696 0.1
(read/write) 183320 182624 -696 -0.4
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574988 696 0.1
shell LP_CC2652R7 (read only) 688446 689142 696 0.1
(read/write) 157936 157240 -696 -0.4
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 110094 110094 0 0.0
.text 578040 578736 696 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607234 672 0.1
.app_xip_area 465060 465732 672 0.1
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 604350 672 0.1
.app_xip_area 462032 462704 672 0.1
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612078 696 0.1
.app_xip_area 470808 471504 696 0.1
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657248 657920 672 0.1
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579672 580344 672 0.1
lock k32w061+release (read/write) 718860 719548 688 0.1
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 641568 688 0.1
linux all-clusters-app debug (read only) 2923761 2925585 1824 0.1
(read/write) 188528 188528 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84488 84488 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2489906 2491730 1824 0.1
all-clusters-minimal-app debug (read only) 2769193 2771017 1824 0.1
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2337458 2339282 1824 0.1
bridge-app debug+rpc (read only) 2247553 2250417 2864 0.1
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 191072 32 0.0
.text 1896530 1899362 2832 0.1
chip-tool debug (read only) 9815973 9818085 2112 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7870661 2112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499865 2400 0.1
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 207176 32 0.0
.text 2122130 2124498 2368 0.1
lock-app debug (read only) 2443465 2445849 2384 0.1
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 221192 0 0.0
.text 2059074 2061458 2384 0.1
ota-provider-app debug (read only) 2281729 2284401 2672 0.1
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 197368 32 0.0
.text 1923202 1925842 2640 0.1
ota-requestor-app debug (read only) 2329289 2331961 2672 0.1
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 199552 32 0.0
.text 1964738 1967378 2640 0.1
shell debug (read only) 2604841 2606697 1856 0.1
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229810 32 0.0
.text 2215746 2217570 1824 0.1
thermostat-no-ble arm64 (read only) 2557916 2559572 1656 0.1
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 161356 24 0.0
.text 2158912 2160544 1632 0.1
tv-app debug (read only) 3050873 3053849 2976 0.1
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 242720 0 0.0
.text 2622370 2625346 2976 0.1
tv-casting-app debug (read only) 5349977 5351801 1824 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 342368 0 0.0
.text 4656338 4658162 1824 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2433680 872 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198987 672 0.1
bss 141617 141617 0 0.0
rodata 156100 156100 0 0.0
text 821652 822320 668 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144203 672 0.1
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 792640 668 0.1
p6 all-clusters-app default (read/write) 2551672 2552616 944 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1509936 1510880 944 0.1
all-clusters-minimal-app default (read/write) 2494128 2495072 944 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1453336 944 0.1
light-app default (read/write) 2425560 2426504 944 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383824 1384768 944 0.1
lock-app default (read/write) 2445968 2446912 944 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1405176 944 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787676 952 0.1
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556634 557586 952 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807656 952 0.1
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573328 574276 948 0.2

@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19531: Size comparison from 0e9b2cc to 4a69a1d

Increases (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc 4a69a1d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658999 704 0.1
.text 570960 571664 704 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645523 688 0.1
.text 554480 555168 688 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688387 680 0.1
.text 588364 589044 680 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637803 688 0.1
.text 537884 538572 688 0.1
pump-app LP_CC2652R7 (read only) 669083 669795 712 0.1
.text 581620 582332 712 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660351 696 0.1
.text 574292 574988 696 0.1
shell LP_CC2652R7 (read only) 688446 689142 696 0.1
.text 578040 578736 696 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607234 672 0.1
.app_xip_area 465060 465732 672 0.1
lock cyw930739m2evb_01 (read/write) 603678 604350 672 0.1
.app_xip_area 462032 462704 672 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612078 696 0.1
.app_xip_area 470808 471504 696 0.1
k32w light k32w061+release (read/write) 657248 657920 672 0.1
.text 579672 580344 672 0.1
lock k32w061+release (read/write) 718860 719548 688 0.1
.text 640880 641568 688 0.1
linux all-clusters-app debug (read only) 2923761 2925585 1824 0.1
.text 2489906 2491730 1824 0.1
all-clusters-minimal-app debug (read only) 2769193 2771017 1824 0.1
.text 2337458 2339282 1824 0.1
bridge-app debug+rpc (read only) 2247553 2250417 2864 0.1
.rodata 191040 191072 32 0.0
.text 1896530 1899362 2832 0.1
chip-tool debug (read only) 9815973 9818085 2112 0.0
.text 7868549 7870661 2112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499865 2400 0.1
.rodata 207144 207176 32 0.0
.text 2122130 2124498 2368 0.1
lock-app debug (read only) 2443465 2445849 2384 0.1
.text 2059074 2061458 2384 0.1
ota-provider-app debug (read only) 2281729 2284401 2672 0.1
.rodata 197336 197368 32 0.0
.text 1923202 1925842 2640 0.1
ota-requestor-app debug (read only) 2329289 2331961 2672 0.1
.rodata 199520 199552 32 0.0
.text 1964738 1967378 2640 0.1
shell debug (read only) 2604841 2606697 1856 0.1
.rodata 229778 229810 32 0.0
.text 2215746 2217570 1824 0.1
thermostat-no-ble arm64 (read only) 2557916 2559572 1656 0.1
.rodata 161332 161356 24 0.0
.text 2158912 2160544 1632 0.1
tv-app debug (read only) 3050873 3053849 2976 0.1
.text 2622370 2625346 2976 0.1
tv-casting-app debug (read only) 5349977 5351801 1824 0.0
.text 4656338 4658162 1824 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2432808 2433680 872 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198987 672 0.1
text 821652 822320 668 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144203 672 0.1
text 791972 792640 668 0.1
p6 all-clusters-app default (read/write) 2551672 2552616 944 0.0
.text 1509936 1510880 944 0.1
all-clusters-minimal-app default (read/write) 2494128 2495072 944 0.0
.text 1452392 1453336 944 0.1
light-app default (read/write) 2425560 2426504 944 0.0
.text 1383824 1384768 944 0.1
lock-app default (read/write) 2445968 2446912 944 0.0
.text 1404232 1405176 944 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787676 952 0.1
text 556634 557588 954 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807656 952 0.1
text 573328 574280 952 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section 0e9b2cc 4a69a1d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192592 191888 -704 -0.4
lock-ftd LP_CC2652R7 (read/write) 154252 153572 -680 -0.4
pump-app LP_CC2652R7 (read/write) 173788 173076 -712 -0.4
pump-controller-app LP_CC2652R7 (read/write) 183320 182624 -696 -0.4
shell LP_CC2652R7 (read/write) 157936 157240 -696 -0.4
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc 4a69a1d change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658999 704 0.1
(read/write) 192592 191888 -704 -0.4
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 87023 87023 0 0.0
.text 570960 571664 704 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645523 688 0.1
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 555168 688 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688387 680 0.1
(read/write) 154252 153572 -680 -0.4
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 589044 680 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637803 688 0.1
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 538572 688 0.1
pump-app LP_CC2652R7 (read only) 669083 669795 712 0.1
(read/write) 173788 173076 -712 -0.4
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 582332 712 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660351 696 0.1
(read/write) 183320 182624 -696 -0.4
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574988 696 0.1
shell LP_CC2652R7 (read only) 688446 689142 696 0.1
(read/write) 157936 157240 -696 -0.4
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 110094 110094 0 0.0
.text 578040 578736 696 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607234 672 0.1
.app_xip_area 465060 465732 672 0.1
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 604350 672 0.1
.app_xip_area 462032 462704 672 0.1
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612078 696 0.1
.app_xip_area 470808 471504 696 0.1
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657248 657920 672 0.1
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579672 580344 672 0.1
lock k32w061+release (read/write) 718860 719548 688 0.1
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 641568 688 0.1
linux all-clusters-app debug (read only) 2923761 2925585 1824 0.1
(read/write) 188528 188528 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84488 84488 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2489906 2491730 1824 0.1
all-clusters-minimal-app debug (read only) 2769193 2771017 1824 0.1
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2337458 2339282 1824 0.1
bridge-app debug+rpc (read only) 2247553 2250417 2864 0.1
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 191072 32 0.0
.text 1896530 1899362 2832 0.1
chip-tool debug (read only) 9815973 9818085 2112 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7870661 2112 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499865 2400 0.1
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 207176 32 0.0
.text 2122130 2124498 2368 0.1
lock-app debug (read only) 2443465 2445849 2384 0.1
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 221192 0 0.0
.text 2059074 2061458 2384 0.1
ota-provider-app debug (read only) 2281729 2284401 2672 0.1
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 197368 32 0.0
.text 1923202 1925842 2640 0.1
ota-requestor-app debug (read only) 2329289 2331961 2672 0.1
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 199552 32 0.0
.text 1964738 1967378 2640 0.1
shell debug (read only) 2604841 2606697 1856 0.1
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229810 32 0.0
.text 2215746 2217570 1824 0.1
thermostat-no-ble arm64 (read only) 2557916 2559572 1656 0.1
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 161356 24 0.0
.text 2158912 2160544 1632 0.1
tv-app debug (read only) 3050873 3053849 2976 0.1
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 242720 0 0.0
.text 2622370 2625346 2976 0.1
tv-casting-app debug (read only) 5349977 5351801 1824 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 342368 0 0.0
.text 4656338 4658162 1824 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2433680 872 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1396324 872 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198987 672 0.1
bss 141617 141617 0 0.0
rodata 156100 156100 0 0.0
text 821652 822320 668 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144203 672 0.1
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 792640 668 0.1
p6 all-clusters-app default (read/write) 2551672 2552616 944 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1509936 1510880 944 0.1
all-clusters-minimal-app default (read/write) 2494128 2495072 944 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1453336 944 0.1
light-app default (read/write) 2425560 2426504 944 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383824 1384768 944 0.1
lock-app default (read/write) 2445968 2446912 944 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1405176 944 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787676 952 0.1
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556634 557588 954 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807656 952 0.1
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573328 574280 952 0.2

bzbarsky-apple
bzbarsky-apple requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Darwin bits need something slightly different....

src/controller/CommissioningDelegate.h Outdated Show resolved Hide resolved
src/credentials/FabricTable.cpp Outdated Show resolved Hide resolved
src/credentials/FabricTable.h Outdated Show resolved Hide resolved
src/darwin/Framework/CHIP/CHIPDeviceController.mm Show resolved Hide resolved
@boring-cyborg boring-cyborg bot added the crypto label Jun 13, 2022
@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

PR #19531: Size comparison from 0e9b2cc to c7a2f29

Increases (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc c7a2f29 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658927 632 0.1
.text 570960 571592 632 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645467 632 0.1
.text 554480 555112 632 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688323 616 0.1
.text 588364 588980 616 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637739 624 0.1
.text 537884 538508 624 0.1
pump-app LP_CC2652R7 (read only) 669083 669723 640 0.1
.text 581620 582260 640 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660279 624 0.1
.text 574292 574916 624 0.1
shell LP_CC2652R7 (read only) 688446 689070 624 0.1
.text 578040 578664 624 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607170 608 0.1
.app_xip_area 465060 465668 608 0.1
lock cyw930739m2evb_01 (read/write) 603678 604286 608 0.1
.app_xip_area 462032 462640 608 0.1
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612006 624 0.1
.app_xip_area 470808 471432 624 0.1
k32w light k32w061+release (read/write) 657248 657856 608 0.1
.text 579672 580280 608 0.1
lock k32w061+release (read/write) 718860 719484 624 0.1
.text 640880 641504 624 0.1
linux all-clusters-app debug (read only) 2923761 2925297 1536 0.1
.text 2489906 2491442 1536 0.1
all-clusters-minimal-app debug (read only) 2769193 2770729 1536 0.1
.text 2337458 2338994 1536 0.1
bridge-app debug+rpc (read only) 2247553 2250129 2576 0.1
.rodata 191040 191072 32 0.0
.text 1896530 1899074 2544 0.1
chip-tool debug (read only) 9815973 9817813 1840 0.0
.text 7868549 7870389 1840 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499593 2128 0.1
.rodata 207144 207176 32 0.0
.text 2122130 2124226 2096 0.1
lock-app debug (read only) 2443465 2445561 2096 0.1
.text 2059074 2061170 2096 0.1
ota-provider-app debug (read only) 2281729 2284113 2384 0.1
.rodata 197336 197368 32 0.0
.text 1923202 1925554 2352 0.1
ota-requestor-app debug (read only) 2329289 2331673 2384 0.1
.rodata 199520 199552 32 0.0
.text 1964738 1967090 2352 0.1
shell debug (read only) 2604841 2606409 1568 0.1
.rodata 229778 229810 32 0.0
.text 2215746 2217282 1536 0.1
thermostat-no-ble arm64 (read only) 2557916 2559556 1640 0.1
.rodata 161332 161356 24 0.0
.text 2158912 2160528 1616 0.1
tv-app debug (read only) 3050873 3053577 2704 0.1
.text 2622370 2625074 2704 0.1
tv-casting-app debug (read only) 5349977 5351513 1536 0.0
.text 4656338 4657874 1536 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2432808 2433616 808 0.0
.text 1395452 1396260 808 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198923 608 0.1
text 821652 822248 596 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144139 608 0.1
text 791972 792572 600 0.1
p6 all-clusters-app default (read/write) 2551672 2552488 816 0.0
.text 1509936 1510752 816 0.1
all-clusters-minimal-app default (read/write) 2494128 2494944 816 0.0
.text 1452392 1453208 816 0.1
light-app default (read/write) 2425560 2426360 800 0.0
.text 1383824 1384624 800 0.1
lock-app default (read/write) 2445968 2446768 800 0.0
.text 1404232 1405032 800 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787588 864 0.1
text 556634 557504 870 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807576 872 0.1
text 573328 574200 872 0.2
Decreases (5 builds for cc13x2_26x2)
platform target config section 0e9b2cc c7a2f29 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 192592 191960 -632 -0.3
lock-ftd LP_CC2652R7 (read/write) 154252 153636 -616 -0.4
pump-app LP_CC2652R7 (read/write) 173788 173148 -640 -0.4
pump-controller-app LP_CC2652R7 (read/write) 183320 182696 -624 -0.3
shell LP_CC2652R7 (read/write) 157936 157312 -624 -0.4
Full report (34 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 0e9b2cc c7a2f29 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 658295 658927 632 0.1
(read/write) 192592 191960 -632 -0.3
.bss 73780 73780 0 0.0
.data 3416 3416 0 0.0
.rodata 87023 87023 0 0.0
.text 570960 571592 632 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 644835 645467 632 0.1
(read/write) 157276 157276 0 0.0
.bss 73004 73004 0 0.0
.data 3356 3356 0 0.0
.rodata 90035 90035 0 0.0
.text 554480 555112 632 0.1
lock-ftd LP_CC2652R7 (read only) 687707 688323 616 0.1
(read/write) 154252 153636 -616 -0.4
.bss 71740 71740 0 0.0
.data 3280 3280 0 0.0
.rodata 98859 98859 0 0.0
.text 588364 588980 616 0.1
lock-mtd LP_CC2652R7 (read only) 637115 637739 624 0.1
(read/write) 144872 144872 0 0.0
.bss 67476 67476 0 0.0
.data 3280 3280 0 0.0
.rodata 98739 98739 0 0.0
.text 537884 538508 624 0.1
pump-app LP_CC2652R7 (read only) 669083 669723 640 0.1
(read/write) 173788 173148 -640 -0.4
.bss 71884 71884 0 0.0
.data 3316 3316 0 0.0
.rodata 86979 86979 0 0.0
.text 581620 582260 640 0.1
pump-controller-app LP_CC2652R7 (read only) 659655 660279 624 0.1
(read/write) 183320 182696 -624 -0.3
.bss 71988 71988 0 0.0
.data 3276 3276 0 0.0
.rodata 84879 84879 0 0.0
.text 574292 574916 624 0.1
shell LP_CC2652R7 (read only) 688446 689070 624 0.1
(read/write) 157936 157312 -624 -0.4
.bss 76076 76076 0 0.0
.data 3420 3420 0 0.0
.rodata 110094 110094 0 0.0
.text 578040 578664 624 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 606562 607170 608 0.1
.app_xip_area 465060 465668 608 0.1
.bss 84432 84432 0 0.0
.data 756 756 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 603678 604286 608 0.1
.app_xip_area 462032 462640 608 0.1
.bss 84608 84608 0 0.0
.data 724 724 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 611382 612006 624 0.1
.app_xip_area 470808 471432 624 0.1
.bss 83616 83616 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 657248 657856 608 0.1
.bss 69748 69748 0 0.0
.data 2028 2028 0 0.0
.text 579672 580280 608 0.1
lock k32w061+release (read/write) 718860 719484 624 0.1
.bss 70180 70180 0 0.0
.data 2000 2000 0 0.0
.text 640880 641504 624 0.1
linux all-clusters-app debug (read only) 2923761 2925297 1536 0.1
(read/write) 188528 188528 0 0.0
.bss 95776 95776 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84488 84488 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258205 258205 0 0.0
.text 2489906 2491442 1536 0.1
all-clusters-minimal-app debug (read only) 2769193 2770729 1536 0.1
(read/write) 179888 179888 0 0.0
.bss 94944 94944 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 76872 76872 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 258621 258621 0 0.0
.text 2337458 2338994 1536 0.1
bridge-app debug+rpc (read only) 2247553 2250129 2576 0.1
(read/write) 158752 158752 0 0.0
.bss 82976 82976 0 0.0
.data 3760 3760 0 0.0
.data.rel.ro 66232 66232 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 191040 191072 32 0.0
.text 1896530 1899074 2544 0.1
chip-tool debug (read only) 9815973 9817813 1840 0.0
(read/write) 623496 623496 0 0.0
.bss 25440 25440 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 590696 590696 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 506805 506805 0 0.0
.text 7868549 7870389 1840 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9563860 9565420 1560 0.0
(read/write) 689841 689841 0 0.0
.bss 43697 43697 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 626128 626128 0 0.0
.dynamic 528 528 0 0.0
.got 15056 15056 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 468788 468812 24 0.0
.text 7518980 7520516 1536 0.0
lighting-app debug+rpc (read only) 2497465 2499593 2128 0.1
(read/write) 163416 163416 0 0.0
.bss 84288 84288 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71176 71176 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 207144 207176 32 0.0
.text 2122130 2124226 2096 0.1
lock-app debug (read only) 2443465 2445561 2096 0.1
(read/write) 158488 158488 0 0.0
.bss 82944 82944 0 0.0
.data 1552 1552 0 0.0
.data.rel.ro 68120 68120 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 221192 221192 0 0.0
.text 2059074 2061170 2096 0.1
ota-provider-app debug (read only) 2281729 2284113 2384 0.1
(read/write) 152688 152688 0 0.0
.bss 82624 82624 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 62456 62456 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 197336 197368 32 0.0
.text 1923202 1925554 2352 0.1
ota-requestor-app debug (read only) 2329289 2331673 2384 0.1
(read/write) 155504 155504 0 0.0
.bss 83328 83328 0 0.0
.data 1976 1976 0 0.0
.data.rel.ro 64392 64392 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 199520 199552 32 0.0
.text 1964738 1967090 2352 0.1
shell debug (read only) 2604841 2606409 1568 0.1
(read/write) 219384 219384 0 0.0
.bss 134568 134568 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 229778 229810 32 0.0
.text 2215746 2217282 1536 0.1
thermostat-no-ble arm64 (read only) 2557916 2559556 1640 0.1
(read/write) 191409 191409 0 0.0
.bss 99377 99377 0 0.0
.data 1560 1560 0 0.0
.data.rel.ro 82376 82376 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 161332 161356 24 0.0
.text 2158912 2160528 1616 0.1
tv-app debug (read only) 3050873 3053577 2704 0.1
(read/write) 289864 289864 0 0.0
.bss 200200 200200 0 0.0
.data 4688 4688 0 0.0
.data.rel.ro 78528 78528 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 242720 242720 0 0.0
.text 2622370 2625074 2704 0.1
tv-casting-app debug (read only) 5349977 5351513 1536 0.0
(read/write) 232312 232312 0 0.0
.bss 88072 88072 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 135528 135528 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 342368 342368 0 0.0
.text 4656338 4657874 1536 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2432808 2433616 808 0.0
.bss 208988 208988 0 0.0
.data 5888 5888 0 0.0
.text 1395452 1396260 808 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1198315 1198923 608 0.1
bss 141617 141617 0 0.0
rodata 156100 156100 0 0.0
text 821652 822248 596 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1143531 1144139 608 0.1
bss 140808 140808 0 0.0
rodata 131828 131828 0 0.0
text 791972 792572 600 0.1
p6 all-clusters-app default (read/write) 2551672 2552488 816 0.0
.bss 143408 143408 0 0.0
.data 2832 2832 0 0.0
.text 1509936 1510752 816 0.1
all-clusters-minimal-app default (read/write) 2494128 2494944 816 0.0
.bss 142624 142624 0 0.0
.data 2776 2776 0 0.0
.text 1452392 1453208 816 0.1
light-app default (read/write) 2425560 2426360 800 0.0
.bss 135736 135736 0 0.0
.data 2624 2624 0 0.0
.text 1383824 1384624 800 0.1
lock-app default (read/write) 2445968 2446768 800 0.0
.bss 135560 135560 0 0.0
.data 2600 2600 0 0.0
.text 1404232 1405032 800 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786724 787588 864 0.1
bss 70876 70876 0 0.0
noinit 40416 40416 0 0.0
text 556634 557504 870 0.2
lighting-app tlsr9518adk80d (read/write) 806704 807576 872 0.1
bss 71128 71128 0 0.0
noinit 40416 40416 0 0.0
text 573328 574200 872 0.2

@tcarmelveilleux tcarmelveilleux merged commit 8cbfd2f into project-chip:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@andy31415 andy31415 Awaiting requested review from andy31415

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
app controller crypto darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcarmelveilleux @andy31415 @msandstedt @bzbarsky-apple @restyled-commits