-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inet] Add Openthread Native ipv6 address #17352
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_native_openthread_ipv6_addr
Apr 14, 2022
Merged
[Inet] Add Openthread Native ipv6 address #17352
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:add_native_openthread_ipv6_addr
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk and
sagar-apple
April 13, 2022 18:35
pullapprove
bot
requested review from
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
April 13, 2022 18:35
jepenven-silabs
force-pushed
the
add_native_openthread_ipv6_addr
branch
from
April 13, 2022 18:37
b86817b
to
0da697c
Compare
tcarmelveilleux
approved these changes
Apr 13, 2022
PR #17352: Size comparison from a76f75e to 0da697c Decreases (3 builds for efr32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
LwIP is used as a wrapper inside the Inet layer. This cause bloating for Native OpenThread implementation of Matter since there is a duplications of API and libs.
Change overview
Add OpenThread native IPV6 address api in IPAddress.cpp
Add InterfaceIterator implementation for platform with only 1 OpenThread interface.
Testing
Tested with EFR32 and Unit Test