Dnssd separate interface between operational and commissionable #15464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eric dnssd resolver delegate interface
…d of all interfaces + error log virtual methods
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13 and
harimau-qirex
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #15464: Size comparison from 22dc4c6 to 442be8a Decreases (27 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Full report (29 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
|
…erits from a commissionabledelegate
|
PR #15464: Size comparison from 4c68e9b to 77f4250 Increases (8 builds for linux)
Decreases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (41 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Feb 23, 2022
bzbarsky-apple
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Throughout the code we have implemented a 'ResolverDelegate' but often handling only one branch of operational or comissionable (e.g. CommissionableNodeProxy only implements commissioning, CASESession only uses operational) etc.
Change overview
Be explicit on using operational vs commissionable nodes.
Testing
Locally tested compilation. In most cases this is expected to be a NOOP if compile succeeds, except that I at places replaced setDelegate with the appropriate operational/commissionable setter. Expect CI to validate that logic still works.