Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Undefined VendoId Value is 0xFFFF (Not 0x0) #15428

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fixed Undefined VendoId Value is 0xFFFF (Not 0x0) #15428

merged 1 commit into from
Feb 23, 2022

Conversation

emargolis
Copy link
Contributor

Problem

In some places in the code the value 0 is used as Undefined Vendor Id, which is wrong. The correct value is 0xFFFF.

Change overview

fixed

Testing

All existing tests

@boring-cyborg boring-cyborg bot added the lib label Feb 22, 2022
@github-actions
Copy link

github-actions bot commented Feb 22, 2022 •
edited
Loading

PR #15428: Size comparison from 36564e0 to 36c6b63

Increases (24 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section 36564e0 36c6b63 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598702 598714 12 0.0
.app_xip_area 503508 503520 12 0.0
lock cyw930739m2evb_01 (read/write) 556738 556750 12 0.0
.app_xip_area 463088 463100 12 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577786 577798 12 0.0
.app_xip_area 474704 474716 12 0.0
efr32 lighting-app BRD4161A (read only) 915668 915716 48 0.0
.text 915660 915708 48 0.0
BRD4161A+rpc (read only) 944368 944416 48 0.0
.text 944360 944408 48 0.0
window-app BRD4161A (read only) 849960 850008 48 0.0
.text 849952 850000 48 0.0
esp32 all-clusters-app c3devkit (read only) 951290 951296 6 0.0
.flash.text 951290 951296 6 0.0
k32w light k32w061+release (read/write) 691436 691452 16 0.0
.text 606192 606208 16 0.0
lock k32w061+release (read/write) 694196 694212 16 0.0
.text 608712 608728 16 0.0
linux chip-tool-ipv6only arm64 (read only) 8864364 8864380 16 0.0
.text 7489572 7489588 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022211 1022227 16 0.0
text 699792 699804 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 991487 991503 16 0.0
text 679672 679684 12 0.0
nrf52840dongle_nrf52840 (read/write) 1037159 1037175 16 0.0
text 703784 703796 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928854 928870 16 0.0
text 614824 614836 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951203 951219 16 0.0
text 642132 642144 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858678 858694 16 0.0
text 557940 557952 12 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949347 949363 16 0.0
text 641520 641532 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945307 945323 16 0.0
text 637760 637772 12 0.0
p6 all-clusters-app default (read/write) 2490352 2490384 32 0.0
.text 1448616 1448648 32 0.0
light-app default (read/write) 2394328 2394360 32 0.0
.text 1352592 1352624 32 0.0
lock-app default (read/write) 2357888 2357936 48 0.0
.text 1316152 1316200 48 0.0
qpg lighting-app qpg6105+debug (read only) 600316 600324 8 0.0
.text 594996 595004 8 0.0
lock-app qpg6105+debug (read only) 566076 566084 8 0.0
.text 560756 560764 8 0.0
telink lighting-app tlsr9518adk80d text 622718 622722 4 0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 36564e0 36c6b63 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598702 598714 12 0.0
.app_xip_area 503508 503520 12 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556738 556750 12 0.0
.app_xip_area 463088 463100 12 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577786 577798 12 0.0
.app_xip_area 474704 474716 12 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915668 915716 48 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 915660 915708 48 0.0
BRD4161A+rpc (read only) 944368 944416 48 0.0
(read/write) 145568 145568 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 944360 944408 48 0.0
window-app BRD4161A (read only) 849960 850008 48 0.0
(read/write) 126552 126552 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 849952 850000 48 0.0
esp32 all-clusters-app c3devkit (read only) 951290 951296 6 0.0
(read/write) 1399506 1399506 0 0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199768 199768 0 0.0
.flash.text 951290 951296 6 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001251 1001251 0 0.0
(read/write) 464920 464920 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 226896 226896 0 0.0
.flash.text 995867 995867 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691436 691452 16 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606192 606208 16 0.0
lock k32w061+release (read/write) 694196 694212 16 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 608712 608728 16 0.0
linux all-clusters-app debug (read only) 2392465 2392465 0 0.0
(read/write) 148560 148560 0 0.0
.bss 62944 62944 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 78552 78552 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206277 206277 0 0.0
.text 2022866 2022866 0 0.0
bridge-app debug+rpc (read only) 1716165 1716165 0 0.0
(read/write) 93824 93824 0 0.0
.bss 48480 48480 0 0.0
.data 2042 2042 0 0.0
.data.rel.ro 38232 38232 0 0.0
.dynamic 592 592 0 0.0
.got 3912 3912 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140372 140372 0 0.0
.text 1459749 1459749 0 0.0
chip-tool debug (read only) 9153357 9153357 0 0.0
(read/write) 321584 321584 0 0.0
.bss 41016 41016 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 273352 273352 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 479541 479541 0 0.0
.text 8011653 8011653 0 0.0
chip-tool-ipv6only arm64 (read only) 8864364 8864380 16 0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456468 456468 0 0.0
.text 7489572 7489588 16 0.0
door-lock-app debug (read only) 1931505 1931505 0 0.0
(read/write) 119928 119928 0 0.0
.bss 51168 51168 0 0.0
.data 1050 1050 0 0.0
.data.rel.ro 62352 62352 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 172028 172028 0 0.0
.text 1610706 1610706 0 0.0
lighting-app debug+rpc (read only) 2060889 2060889 0 0.0
(read/write) 124840 124840 0 0.0
.bss 52128 52128 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 65856 65856 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 164497 164497 0 0.0
.text 1741490 1741490 0 0.0
ota-provider-app debug (read only) 1864833 1864833 0 0.0
(read/write) 115592 115592 0 0.0
.bss 51008 51008 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 57672 57672 0 0.0
.dynamic 608 608 0 0.0
.got 4352 4352 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 156819 156819 0 0.0
.text 1557138 1557138 0 0.0
ota-requestor-app debug (read only) 1877281 1877281 0 0.0
(read/write) 117392 117392 0 0.0
.bss 51872 51872 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 58936 58936 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 150980 150980 0 0.0
.text 1577106 1577106 0 0.0
shell debug (read only) 2361449 2361449 0 0.0
(read/write) 151072 151072 0 0.0
.bss 71296 71296 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73280 73280 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206514 206514 0 0.0
.text 1997826 1997826 0 0.0
thermostat-no-ble arm64 (read only) 2160300 2160300 0 0.0
(read/write) 149873 149873 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75216 75216 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132684 132684 0 0.0
.text 1808912 1808912 0 0.0
tv-app debug (read only) 2586817 2586817 0 0.0
(read/write) 152208 152208 0 0.0
.bss 69120 69120 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73864 73864 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 199477 199477 0 0.0
.text 2212882 2212882 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439900 2439900 0 0.0
.bss 194612 194612 0 0.0
.data 5360 5360 0 0.0
.text 1402472 1402472 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2401084 2401084 0 0.0
.bss 188712 188712 0 0.0
.data 5656 5656 0 0.0
.text 1363656 1363656 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336776 2336776 0 0.0
.bss 187608 187608 0 0.0
.data 5632 5632 0 0.0
.text 1299376 1299376 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327484 2327484 0 0.0
.bss 186244 186244 0 0.0
.data 5464 5464 0 0.0
.text 1290056 1290056 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022211 1022227 16 0.0
bss 122664 122664 0 0.0
rodata 120760 120760 0 0.0
text 699792 699804 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 991487 991503 16 0.0
bss 119852 119852 0 0.0
rodata 112284 112284 0 0.0
text 679672 679684 12 0.0
nrf52840dongle_nrf52840 (read/write) 1037159 1037175 16 0.0
bss 123868 123868 0 0.0
rodata 119608 119608 0 0.0
text 703784 703796 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928854 928870 16 0.0
bss 119224 119224 0 0.0
rodata 114016 114016 0 0.0
text 614824 614836 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951203 951219 16 0.0
bss 120876 120876 0 0.0
rodata 109600 109600 0 0.0
text 642132 642144 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858678 858694 16 0.0
bss 117468 117468 0 0.0
rodata 102768 102768 0 0.0
text 557940 557952 12 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949347 949363 16 0.0
bss 120596 120596 0 0.0
rodata 108552 108552 0 0.0
text 641520 641532 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945307 945323 16 0.0
bss 120600 120600 0 0.0
rodata 108248 108248 0 0.0
text 637760 637772 12 0.0
shell nrf52840dk_nrf52840 (read/write) 811651 811651 0 0.0
bss 113348 113348 0 0.0
rodata 79752 79752 0 0.0
text 540924 540924 0 0.0
p6 all-clusters-app default (read/write) 2490352 2490384 32 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1448616 1448648 32 0.0
light-app default (read/write) 2394328 2394360 32 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1352592 1352624 32 0.0
lock-app default (read/write) 2357888 2357936 48 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1316152 1316200 48 0.0
qpg lighting-app qpg6105+debug (read only) 600316 600324 8 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 594996 595004 8 0.0
lock-app qpg6105+debug (read only) 566076 566084 8 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 560756 560764 8 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 881410 881410 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 622718 622722 4 0.0

@mlepage-google
Copy link
Contributor

0x0000 is absolutely a valid vendor ID, it's the standard one (i.e. Matter itself).

@mlepage-google
Copy link
Contributor

You can see examples of using tables which partition the range of values, plus code to loop through the tables, to test all possible combinations (valid and invalid) here in TestAccessControl.cpp.

@bzbarsky-apple bzbarsky-apple merged commit 22dc4c6 into project-chip:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlepage-google mlepage-google mlepage-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @mlepage-google @tcarmelveilleux @bzbarsky-apple