Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodules for nlio, nlassert and nlunit-test #15

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Add submodules for nlio, nlassert and nlunit-test #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
946e804
Add submodules for nlio, nlassert and nlunit-test
pan-apple Mar 7, 2020
b2b09fb
Move git submodules to third_party/<module>/repo
pan-apple Mar 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
[submodule "third_party/nlio"]
path = third_party/nlio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advocate third_party/nlio/repo, this leaves room for glue between third_party/nlio and third_part/nlio/repo, if necessary, as a design pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerickson done

url = https://github.com/nestlabs/nlio.git
branch = master
[submodule "third_party/nlassert"]
path = third_party/nlassert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advocate third_party/nlassert/repo, this leaves room for glue between third_party/nlassert and third_part/nlassert/repo, if necessary, as a design pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

url = https://github.com/nestlabs/nlassert.git
branch = master
[submodule "third_party/nlunit-test"]
path = third_party/nlunit-test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd advocate third_party/nlunit-test/repo, this leaves room for glue between third_party/nlunit-test and third_part/nlunit-test/repo, if necessary, as a design pattern.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

url = https://github.com/nestlabs/nlunit-test.git
branch = master
1 change: 1 addition & 0 deletions third_party/nlassert
Open in desktop
Submodule nlassert added at 700bd5
1 change: 1 addition & 0 deletions third_party/nlio
Open in desktop
Submodule nlio added at 9f9f50
1 change: 1 addition & 0 deletions third_party/nlunit-test
Open in desktop
Submodule nlunit-test added at eba920