-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ld file in all-cluster-app/esp32 for tracing #11657
Merged
andy31415
merged 1 commit into
project-chip:master
from
yyzhong-g:add_pw_tokenizer_linker
Nov 11, 2021
Merged
Add a ld file in all-cluster-app/esp32 for tracing #11657
andy31415
merged 1 commit into
project-chip:master
from
yyzhong-g:add_pw_tokenizer_linker
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic and
turon
November 11, 2021 01:28
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 11, 2021 01:28
PR #11657: Size comparison from 9964cdb to 7c2a979 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 11, 2021
Fast tracking, given platform changes by a platform maintainer. |
/rebase |
pw_trace_tokenized backend depends on pw_tokenizer which requires this ld file.
woody-apple
force-pushed
the
add_pw_tokenizer_linker
branch
from
November 11, 2021 16:47
7c2a979
to
95fe12e
Compare
bzbarsky-apple
approved these changes
Nov 11, 2021
PR #11657: Size comparison from dbe2a62 to 95fe12e Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 11, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
pw_trace_tokenized backend depends on pw_tokenizer which requires this ld file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pw_trace_tokenized backend depends on pw_tokenizer which requires
this ld file.
Problem
PR #11203 adds trace functionality to the example but it is missing this ld file.
Change overview
Add pw_tokenizer_linker_sections.ld
Testing
build eps32 all-cluster-app and check string tokenized.