-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release commissionee device once the device is visible on operational network #11592
Release commissionee device once the device is visible on operational network #11592
Conversation
PR #11592: Size comparison from ff5f946 to 38f8827 Increases (2 builds for linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Fast track: ToT is broken, expediting PR that is small. For longer term, I believe this should use some smart pointers/resource management since the free seems very brittle, however that could be done in a followup. |
Adding hotfix. |
Looking into the failure in Cirque task. If it's this PR specific, I'll update the PR. |
38f8827
to
a9bf97a
Compare
PR #11592: Size comparison from e6dab37 to a9bf97a Increases (2 builds for linux)
Full report (26 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
|
Cirque failing log seems to be:
|
PR #11592: Size comparison from e6dab37 to d526283 Increases (2 builds for linux)
Decreases (1 build for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
… network (project-chip#11592) * Release commissionee device once the device is visible on operational network * free commissionee device if pairing fails * fix cirque failures
Problem
The network commissioning is failing after controller code was refactored.
Change overview
The controller was releasing the device handle for the commissionee device once the operational credentials were provisioned. The network commissioning also needs the handle to the device object. Since it was already freed, the network commissioning was failing.
The PR frees the device handle after the device is available on the operational network.
Testing
Tested using chip-tool and m5stack, using BLE pairing.