Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unpaired pragma diagnostic pop. #11407

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Remove unpaired pragma diagnostic pop. #11407

merged 1 commit into from
Nov 4, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

This was missed in
#10681

Problem

pragma diagnostic pop with no corresponding diagnostic push.

Change overview

Remove it.

Testing

Tree still compiles. No behavior changes.

@boring-cyborg boring-cyborg bot added the app label Nov 4, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021 •
edited
Loading

PR #11407: Size comparison from ee7682d to cee972e

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ee7682d cee972e change % change
efr32 lighting-app BRD4161A (read only) 737432 737432 0 0.0
(read/write) 114588 114588 0 0.0
.bss 112828 112828 0 0.0
.data 1756 1756 0 0.0
.text 737424 737424 0 0.0
BRD4161A+rpc (read only) 726628 726628 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129332 129332 0 0.0
.data 1872 1872 0 0.0
.text 726620 726620 0 0.0
lock-app BRD4161A (read only) 716696 716696 0 0.0
(read/write) 112404 112404 0 0.0
.bss 110684 110684 0 0.0
.data 1716 1716 0 0.0
.text 716688 716688 0 0.0
window-app BRD4161A (read only) 717612 717612 0 0.0
(read/write) 112724 112724 0 0.0
.bss 111004 111004 0 0.0
.data 1720 1720 0 0.0
.text 717604 717604 0 0.0
esp32 all-clusters-app c3devkit (read only) 880890 880890 0 0.0
(read/write) 1308120 1308120 0 0.0
.dram0.bss 58584 58584 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199832 199832 0 0.0
.flash.text 880890 880890 0 0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 912007 912007 0 0.0
(read/write) 427876 427876 0 0.0
.dram0.bss 61088 61088 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208524 208524 0 0.0
.flash.text 912007 912007 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77824 77824 0 0.0
.data 1904 1904 0 0.0
.text 614120 614120 0 0.0
lock-app k32w061+debug (read/write) 591956 591956 0 0.0
.bss 68340 68340 0 0.0
.data 1868 1868 0 0.0
.text 515948 515948 0 0.0
shell k32w061+debug (read/write) 657904 657904 0 0.0
.bss 78992 78992 0 0.0
.data 1840 1840 0 0.0
.text 571272 571272 0 0.0
linux all-clusters-app debug (read only) 1697761 1697761 0 0.0
(read/write) 119696 119696 0 0.0
.bss 51120 51120 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62272 62272 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 140469 140469 0 0.0
.text 1423874 1423874 0 0.0
bridge-app debug+rpc (read only) 1292477 1292477 0 0.0
(read/write) 69320 69320 0 0.0
.bss 35024 35024 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27768 27768 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 111780 111780 0 0.0
.text 1084805 1084805 0 0.0
chip-tool debug (read only) 4429253 4429253 0 0.0
(read/write) 125888 125888 0 0.0
.bss 18224 18224 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100032 100032 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 226992 226992 0 0.0
.text 3933941 3933941 0 0.0
lighting-app debug+rpc (read only) 1553505 1553505 0 0.0
(read/write) 102288 102288 0 0.0
.bss 40664 40664 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 130449 130449 0 0.0
.text 1289474 1289474 0 0.0
ota-provider-app debug (read only) 1251761 1251761 0 0.0
(read/write) 67488 67488 0 0.0
.bss 37088 37088 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24568 24568 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 113032 113032 0 0.0
.text 1042626 1042626 0 0.0
ota-requestor-app debug (read only) 1329497 1329497 0 0.0
(read/write) 76744 76744 0 0.0
.bss 45216 45216 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124464 124464 0 0.0
.text 1106978 1106978 0 0.0
shell debug (read only) 786641 786641 0 0.0
(read/write) 57600 57600 0 0.0
.bss 16040 16040 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77839 77839 0 0.0
.text 607314 607314 0 0.0
tv-app debug (read only) 1817113 1817113 0 0.0
(read/write) 289912 289912 0 0.0
.bss 222736 222736 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58824 58824 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 156040 156040 0 0.0
.text 1518786 1518786 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293328 2293328 0 0.0
.bss 179940 179940 0 0.0
.data 5216 5216 0 0.0
.heap 851288 851288 0 0.0
.text 1255928 1255928 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272760 2272760 0 0.0
.bss 171980 171980 0 0.0
.data 5568 5568 0 0.0
.heap 858896 858896 0 0.0
.text 1235360 1235360 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250480 2250480 0 0.0
.bss 170876 170876 0 0.0
.data 5560 5560 0 0.0
.heap 860008 860008 0 0.0
.text 1213080 1213080 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048368 2048368 0 0.0
.bss 156224 156224 0 0.0
.data 4960 4960 0 0.0
.heap 875264 875264 0 0.0
.text 1010968 1010968 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861623 861623 0 0.0
bss 111288 111288 0 0.0
rodata 96808 96808 0 0.0
text 577912 577912 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824003 824003 0 0.0
bss 107640 107640 0 0.0
rodata 87988 87988 0 0.0
text 552100 552100 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786662 786662 0 0.0
bss 112664 112664 0 0.0
rodata 92064 92064 0 0.0
text 507372 507372 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838331 838331 0 0.0
bss 110324 110324 0 0.0
rodata 93180 93180 0 0.0
text 559388 559388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763626 0 0.0
bss 111732 111732 0 0.0
rodata 88484 88484 0 0.0
text 488940 488940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844439 844439 0 0.0
bss 110460 110460 0 0.0
rodata 94888 94888 0 0.0
text 563568 563568 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838183 838183 0 0.0
bss 110360 110360 0 0.0
rodata 93176 93176 0 0.0
text 559124 559124 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775975 775975 0 0.0
bss 109080 109080 0 0.0
rodata 72412 72412 0 0.0
text 519904 519904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691010 691010 0 0.0
bss 110060 110060 0 0.0
rodata 67052 67052 0 0.0
text 440496 440496 0 0.0
p6 all-clusters-app default (read/write) 2301080 2301080 0 0.0
.bss 107880 107880 0 0.0
.data 2520 2520 0 0.0
.heap 922944 922944 0 0.0
.text 1259344 1259344 0 0.0
lock-app default (read/write) 2213928 2213928 0 0.0
.bss 95680 95680 0 0.0
.data 2392 2392 0 0.0
.heap 935272 935272 0 0.0
.text 1172192 1172192 0 0.0
qpg lighting-app qpg6100+debug (read only) 490932 490932 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50968 50968 0 0.0
.data 1004 1004 0 0.0
.text 485612 485612 0 0.0
lock-app qpg6100+debug (read only) 467280 467280 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49912 49912 0 0.0
.data 960 960 0 0.0
.text 461960 461960 0 0.0
persistent-storage-app qpg6100+debug (read only) 153212 153212 0 0.0
(read/write) 114140 114140 0 0.0
.bss 18920 18920 0 0.0
.data 356 356 0 0.0
.text 147892 147892 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663086 663086 0 0.0
bss 69100 69100 0 0.0
noinit 33216 33216 0 0.0
text 458206 458206 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, looks like this is a build configuration change

@woody-apple woody-apple merged commit 56e15c5 into project-chip:master Nov 4, 2021
@bzbarsky-apple bzbarsky-apple deleted the remove-extra-pragma-pop branch November 4, 2021 14:23
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Remove unpaired pragma diagnostic pop. (project-chip#11407)
7d2ab78 
This was missed in
project-chip#10681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @woody-apple @Damian-Nordic