-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of external storage in Bridged Actions cluster #11381
Merged
andy31415
merged 2 commits into
project-chip:master
from
pjzander-signify:use_external_storage_in_cluster
Nov 4, 2021
Merged
Use of external storage in Bridged Actions cluster #11381
andy31415
merged 2 commits into
project-chip:master
from
pjzander-signify:use_external_storage_in_cluster
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tecimovic
November 3, 2021 17:26
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 3, 2021 17:26
andy31415
approved these changes
Nov 3, 2021
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
PR #11381: Size comparison from 4fe7712 to f61ccdf Increases above 0.2%:
Increases (4 builds for esp32, linux, mbed, p6)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 3, 2021
bzbarsky-apple
approved these changes
Nov 3, 2021
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
examples/all-clusters-app/linux/include/bridged-actions-stub.cpp
Outdated
Show resolved
Hide resolved
pjzander-signify
force-pushed
the
use_external_storage_in_cluster
branch
from
November 4, 2021 08:50
f61ccdf
to
da74f53
Compare
PR #11381: Size comparison from ee7682d to da74f53 Increases above 0.2%:
Increases (4 builds for esp32, linux, mbed, p6)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mspang
pushed a commit
to mspang/connectedhomeip
that referenced
this pull request
Nov 17, 2021
* Use of external storage in Bridged Actions cluster * Processing review comments (cherry picked from commit 82eeb3a)
andy31415
pushed a commit
that referenced
this pull request
Nov 18, 2021
* Use of external storage in Bridged Actions cluster * Processing review comments (cherry picked from commit 82eeb3a)
doru91
pushed a commit
to doru91/connectedhomeip
that referenced
this pull request
Dec 2, 2021
* Use of external storage in Bridged Actions cluster * Processing review comments (cherry picked from commit 82eeb3a)
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Use of external storage in Bridged Actions cluster * Processing review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because the chip-tool uses the client implementation of the Bridged Actions cluster, the all-cluster-app must use the server side of this cluster, else the Darwin workflow will fail.
Currently the Bridged Actions cluster is using RAM as the storage for the attributes. This increases the memory footprint of the all-clusters-app. Therefore we must provide an implementation that works with external storage of these attributes.
Change overview
Testing