Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chip::Protocols::InteractionModel::Status for ZCL status #10281

Conversation

vivien-apple
Copy link
Contributor

Problem

PR #10171 is trying to add a special case for argument using the Status atomic type. This PR convert some places into our xml definitions to avoid the need for the special casing.

Change overview

  • Update XML definitions that were using Status type but wants to use enum8 instead since Status is an enum16
  • Add some mapping to replace chip::StatusCode by chip::Protocols::InteractionModel::Status
  • Remove the Status definition from src/app/zap-templates/zcl/data-model/silabs/types.xml in order to let us overrides it with some type not managed by ZAP.

Testing

The generated code that has changed is not code that is used at the moment, so the final binary has not changed.

@vivien-apple vivien-apple force-pushed the ZAP_InteractionModel_Status_InsteadOf_uint8_t branch from 116003e to 6e78b18 Compare October 6, 2021 16:32
@kpschoedel
Copy link
Contributor

PR #10281: Size comparison from 4a321fe to 6e78b18

22 builds
platform target config section 4a321fe 6e78b18 change % change
efr32 lighting-app BRD4161A .bss 117940 117940 0 0.0
.data 1796 1796 0 0.0
.text 779664 779664 0 0.0
lock-app BRD4161A .bss 115380 115380 0 0.0
.data 1756 1756 0 0.0
.text 757964 757964 0 0.0
window-app BRD4161A .bss 117020 117020 0 0.0
.data 1760 1760 0 0.0
.text 759376 759376 0 0.0
lighting-app BRD4161A+rpc .bss 131276 131276 0 0.0
.data 1848 1848 0 0.0
.text 758420 758420 0 0.0
k32w lock-app k32w061+debug .bss 68588 68588 0 0.0
.data 1860 1860 0 0.0
.text 514876 514876 0 0.0
shell k32w061+debug .bss 55064 55064 0 0.0
.data 672 672 0 0.0
.text 355596 355596 0 0.0
lighting-app k32w061+se05x+release .bss 78528 78528 0 0.0
.data 1896 1896 0 0.0
.text 614156 614156 0 0.0
linux all-clusters-app debug .bss 58032 58032 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 58272 58272 0 0.0
.dynamic 592 592 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 134133 134133 0 0.0
.text 1265538 1265538 0 0.0
chip-tool debug .bss 18960 18960 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 76912 76912 0 0.0
.dynamic 592 592 0 0.0
.got 4344 4344 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 173144 173144 0 0.0
.text 2405445 2405445 0 0.0
ota-provider-app debug .bss 37344 37344 0 0.0
.data 752 752 0 0.0
.data.rel.ro 22808 22808 0 0.0
.dynamic 592 592 0 0.0
.got 3968 3968 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 106544 106544 0 0.0
.text 970754 970754 0 0.0
ota-requestor-app debug .bss 204664 204664 0 0.0
.data 704 704 0 0.0
.data.rel.ro 23520 23520 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 113278 113278 0 0.0
.text 1036498 1036498 0 0.0
shell debug .bss 16104 16104 0 0.0
.data 242 242 0 0.0
.data.rel.ro 35192 35192 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 70159 70159 0 0.0
.text 570482 570482 0 0.0
tv-app debug .bss 218240 218240 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 54328 54328 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 144558 144558 0 0.0
.text 1397298 1397298 0 0.0
bridge-app debug+rpc .bss 54384 54384 0 0.0
.data 976 976 0 0.0
.data.rel.ro 25384 25384 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 107896 107896 0 0.0
.text 1028597 1028597 0 0.0
lighting-app debug+rpc .bss 42904 42904 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 51744 51744 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 123345 123345 0 0.0
.text 1213410 1213410 0 0.0
mbed lighting-app CY8CPROTO_062_4343W+release .bss 172060 172060 0 0.0
.data 5368 5368 0 0.0
.heap 859016 859016 0 0.0
.text 1151144 1151144 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170564 170564 0 0.0
.data 5344 5344 0 0.0
.heap 860536 860536 0 0.0
.text 1128032 1128032 0 0.0
p6 lock-app default .bss 67776 67776 0 0.0
.data 2416 2416 0 0.0
.heap 963152 963152 0 0.0
.text 1124920 1124920 0 0.0
qpg lighting-app qpg6100+debug .bss 53528 53528 0 0.0
.data 1000 1000 0 0.0
.text 486116 486116 0 0.0
lock-app qpg6100+debug .bss 52048 52048 0 0.0
.data 956 956 0 0.0
.text 461524 461524 0 0.0
persistent-storage-app qpg6100+debug .bss 17802 17802 0 0.0
.data 284 284 0 0.0
.text 102712 102712 0 0.0
telink lighting-app tlsr9518adk80d bss 71068 71068 0 0.0
noinit 33216 33216 0 0.0
text 459160 459160 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Size increase report for "esp32-example-build" from 4a321fe

File Section File VM
chip-all-clusters-app.elf .flash.text 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,311
.debug_info,0,73
.debug_loc,0,43
.debug_abbrev,0,20
.flash.text,4,4
.riscv.attributes,0,1
[Unmapped],0,-4


@yunhanw-google yunhanw-google merged commit 962faf8 into project-chip:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants