-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chip::Protocols::InteractionModel::Status for ZCL status #10281
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_InteractionModel_Status_InsteadOf_uint8_t
Oct 6, 2021
Merged
Use chip::Protocols::InteractionModel::Status for ZCL status #10281
yunhanw-google
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_InteractionModel_Status_InsteadOf_uint8_t
Oct 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
ZAP_InteractionModel_Status_InsteadOf_uint8_t
branch
from
October 6, 2021 13:35
c1bfb71
to
116003e
Compare
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
turon
October 6, 2021 13:36
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
October 6, 2021 13:36
vivien-apple
force-pushed
the
ZAP_InteractionModel_Status_InsteadOf_uint8_t
branch
from
October 6, 2021 16:32
116003e
to
6e78b18
Compare
bzbarsky-apple
approved these changes
Oct 6, 2021
mrjerryjohns
approved these changes
Oct 6, 2021
yunhanw-google
approved these changes
Oct 6, 2021
saurabhst
approved these changes
Oct 6, 2021
Damian-Nordic
approved these changes
Oct 6, 2021
jmartinez-silabs
approved these changes
Oct 6, 2021
msandstedt
approved these changes
Oct 6, 2021
PR #10281: Size comparison from 4a321fe to 6e78b18 22 builds
|
Size increase report for "esp32-example-build" from 4a321fe
Full report output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #10171 is trying to add a special case for argument using the
Status
atomic type. This PR convert some places into our xml definitions to avoid the need for the special casing.Change overview
Status
type but wants to useenum8
instead sinceStatus
is anenum16
chip::StatusCode
bychip::Protocols::InteractionModel::Status
Status
definition fromsrc/app/zap-templates/zcl/data-model/silabs/types.xml
in order to let us overrides it with some type not managed by ZAP.Testing
The generated code that has changed is not code that is used at the moment, so the final binary has not changed.